code review 3989064: path: work for windows.

path: work for windows.
added IsDirSep, IsVolumeSep, IsSame.
Fixes issue 1483.
Fixes issue 1107.
Fixes issue 1423.

[mattn, 2011-02-04 06:30:52]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
http://go.googlecode.com/hg/

[mattn, 2011-02-04 06:31:48]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bsiegert, 2011-02-04 09:38:47]

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/match.go
File src/pkg/path/match.go (right):

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/match.go#newcode23
src/pkg/path/match.go:23: //		'\\' c      matches character c
I am concerned about using patterns with backslashes in Match. For example,
Match("C:\\*", "C:\autoexec.bat") will not match because "\\*" matches a literal
star, no?

I am not sure how to solve this.

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go
File src/pkg/path/path.go (right):

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode85
src/pkg/path/path.go:85: buf[w] = DirSeps[0]
Is it really necessary to replace a literal slash with DirSeps[0]?

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode119
src/pkg/path/path.go:119: return Clean(strings.Join(elem[i:],
string(DirSeps[0])))
same as above

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode208
src/pkg/path/path.go:208: // IsVolumeSep return true if VolumeSeps include the
letter.
IsVolumeSep returns true if c is a volume separator character.

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode213
src/pkg/path/path.go:213: // IsDirSep return true if DirSeps include the letter.
IsDirSep returns true if c is a directory separator character.

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_test.go
File src/pkg/path/path_test.go (right):

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_test.go#new...
src/pkg/path/path_test.go:326: var basetests []CleanTest
remove, basetests is defined above.

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_unix.go
File src/pkg/path/path_unix.go (right):

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_unix.go#new...
src/pkg/path/path_unix.go:20: return lhs == rhs
On Mac OS X, there are case-insensitive file systems. Should IsSame do
case-insensitive matching in this case?
(If yes, this would be for another CL.)

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_windows.go
File src/pkg/path/path_windows.go (right):

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_windows.go#...
src/pkg/path/path_windows.go:37: // note that this function don't normalize
paths.
s/n/N/
s/don't/does not/

IMHO, the doc comment should mention that it uses different rules on POSIX and
Windows (case-insensitive, forward slash equal to backslash).

[mattn, 2011-02-04 09:54:43]

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go
File src/pkg/path/path.go (right):

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode85
src/pkg/path/path.go:85: buf[w] = DirSeps[0]
This become normalizer replacing slash to backslash for win32.

c:/go/src/package/runtime to c:\go\src\package\runtime

On 2011/02/04 09:38:47, bsiegert wrote:
> Is it really necessary to replace a literal slash with DirSeps[0]?

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode119
src/pkg/path/path.go:119: return Clean(strings.Join(elem[i:],
string(DirSeps[0])))
on win32, DirSeps[0] is backslash. but slash for unix.

On 2011/02/04 09:38:47, bsiegert wrote:
> same as above

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode208
src/pkg/path/path.go:208: // IsVolumeSep return true if VolumeSeps include the
letter.
On 2011/02/04 09:38:47, bsiegert wrote:
> IsVolumeSep returns true if c is a volume separator character.

Done.

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode213
src/pkg/path/path.go:213: // IsDirSep return true if DirSeps include the letter.
On 2011/02/04 09:38:47, bsiegert wrote:
> IsDirSep returns true if c is a directory separator character.

Done.

[mattn, 2011-02-04 09:54:54]

Hello golang-dev@googlegroups.com, bsiegert, r, rsc (cc:
golang-dev@googlegroups.com),

Please take another look.

[mattn, 2011-02-04 09:55:53]

I'll add the comment about slash/backslash.
Thanks for your review.

On 2011/02/04 09:38:47, bsiegert wrote:
> http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/match.go
> File src/pkg/path/match.go (right):
> 
>
http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/match.go#newcode23
> src/pkg/path/match.go:23: //		'\\' c      matches character c
> I am concerned about using patterns with backslashes in Match. For example,
> Match("C:\\*", "C:\autoexec.bat") will not match because "\\*" matches a
literal
> star, no?
> 
> I am not sure how to solve this.
> 
> http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go
> File src/pkg/path/path.go (right):
> 
> http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode85
> src/pkg/path/path.go:85: buf[w] = DirSeps[0]
> Is it really necessary to replace a literal slash with DirSeps[0]?
> 
>
http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode119
> src/pkg/path/path.go:119: return Clean(strings.Join(elem[i:],
> string(DirSeps[0])))
> same as above
> 
>
http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode208
> src/pkg/path/path.go:208: // IsVolumeSep return true if VolumeSeps include the
> letter.
> IsVolumeSep returns true if c is a volume separator character.
> 
>
http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode213
> src/pkg/path/path.go:213: // IsDirSep return true if DirSeps include the
letter.
> IsDirSep returns true if c is a directory separator character.
> 
> http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_test.go
> File src/pkg/path/path_test.go (right):
> 
>
http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_test.go#new...
> src/pkg/path/path_test.go:326: var basetests []CleanTest
> remove, basetests is defined above.
> 
> http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_unix.go
> File src/pkg/path/path_unix.go (right):
> 
>
http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_unix.go#new...
> src/pkg/path/path_unix.go:20: return lhs == rhs
> On Mac OS X, there are case-insensitive file systems. Should IsSame do
> case-insensitive matching in this case?
> (If yes, this would be for another CL.)
> 
> http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_windows.go
> File src/pkg/path/path_windows.go (right):
> 
>
http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_windows.go#...
> src/pkg/path/path_windows.go:37: // note that this function don't normalize
> paths.
> s/n/N/
> s/don't/does not/
> 
> IMHO, the doc comment should mention that it uses different rules on POSIX and
> Windows (case-insensitive, forward slash equal to backslash).

[mattn, 2011-02-04 09:56:45]

Ah sorry.

I didn't fix all. X-(

On 2011/02/04 09:38:47, bsiegert wrote:
> http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/match.go
> File src/pkg/path/match.go (right):
> 
>
http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/match.go#newcode23
> src/pkg/path/match.go:23: //		'\\' c      matches character c
> I am concerned about using patterns with backslashes in Match. For example,
> Match("C:\\*", "C:\autoexec.bat") will not match because "\\*" matches a
literal
> star, no?
> 
> I am not sure how to solve this.
> 
> http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go
> File src/pkg/path/path.go (right):
> 
> http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode85
> src/pkg/path/path.go:85: buf[w] = DirSeps[0]
> Is it really necessary to replace a literal slash with DirSeps[0]?
> 
>
http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode119
> src/pkg/path/path.go:119: return Clean(strings.Join(elem[i:],
> string(DirSeps[0])))
> same as above
> 
>
http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode208
> src/pkg/path/path.go:208: // IsVolumeSep return true if VolumeSeps include the
> letter.
> IsVolumeSep returns true if c is a volume separator character.
> 
>
http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode213
> src/pkg/path/path.go:213: // IsDirSep return true if DirSeps include the
letter.
> IsDirSep returns true if c is a directory separator character.
> 
> http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_test.go
> File src/pkg/path/path_test.go (right):
> 
>
http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_test.go#new...
> src/pkg/path/path_test.go:326: var basetests []CleanTest
> remove, basetests is defined above.
> 
> http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_unix.go
> File src/pkg/path/path_unix.go (right):
> 
>
http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_unix.go#new...
> src/pkg/path/path_unix.go:20: return lhs == rhs
> On Mac OS X, there are case-insensitive file systems. Should IsSame do
> case-insensitive matching in this case?
> (If yes, this would be for another CL.)
> 
> http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_windows.go
> File src/pkg/path/path_windows.go (right):
> 
>
http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_windows.go#...
> src/pkg/path/path_windows.go:37: // note that this function don't normalize
> paths.
> s/n/N/
> s/don't/does not/
> 
> IMHO, the doc comment should mention that it uses different rules on POSIX and
> Windows (case-insensitive, forward slash equal to backslash).

[bsiegert, 2011-02-04 10:02:55]

On Fri, Feb 4, 2011 at 10:54,  <mattn.jp@gmail.com> wrote:
> http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode85
> src/pkg/path/path.go:85: buf[w] = DirSeps[0]
> This become normalizer replacing slash to backslash for win32.
>
> c:/go/src/package/runtime to c:\go\src\package\runtime

Not sure if this is a good idea. Does c:\go\src\package\runtime still
match "c:/go/src/package/*"?

--Benny.

[mattn, 2011-02-04 10:10:49]

Hello golang-dev@googlegroups.com, bsiegert, r, rsc (cc:
golang-dev@googlegroups.com),

Please take another look.

[mattn, 2011-02-04 10:11:19]

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/match.go
File src/pkg/path/match.go (right):

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/match.go#newcode23
src/pkg/path/match.go:23: //		'\\' c      matches character c
This is pattern, developer should know / will be match backslash and backslash
are escape. He shouldn't use backslash as path separator.

On 2011/02/04 09:38:47, bsiegert wrote:
> I am concerned about using patterns with backslashes in Match. For example,
> Match("C:\\*", "C:\autoexec.bat") will not match because "\\*" matches a
literal
> star, no?
> 
> I am not sure how to solve this.

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_test.go
File src/pkg/path/path_test.go (right):

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_test.go#new...
src/pkg/path/path_test.go:326: var basetests []CleanTest
On 2011/02/04 09:38:47, bsiegert wrote:
> remove, basetests is defined above.

Done.

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_unix.go
File src/pkg/path/path_unix.go (right):

http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path_unix.go#new...
src/pkg/path/path_unix.go:20: return lhs == rhs
Yes, I'll path to another CL.
Thanks for notice.

On 2011/02/04 09:38:47, bsiegert wrote:
> On Mac OS X, there are case-insensitive file systems. Should IsSame do
> case-insensitive matching in this case?
> (If yes, this would be for another CL.)

[mattn, 2011-02-04 10:12:38]

> Not sure if this is a good idea. Does c:\go\src\package\runtime still
> match "c:/go/src/package/*"?

Argument of Match is not path. it's patter. We shouldn't treat pattern as path.

[mattn, 2011-02-04 10:13:45]

Or you we should use slash for path separator as default value on windows, I'll
change DirSeps to `/\` from `\/`.

On 2011/02/04 10:02:55, bsiegert wrote:
> On Fri, Feb 4, 2011 at 10:54,  <mailto:mattn.jp@gmail.com> wrote:
> >
http://codereview.appspot.com/3989064/diff/6001/src/pkg/path/path.go#newcode85
> > src/pkg/path/path.go:85: buf[w] = DirSeps[0]
> > This become normalizer replacing slash to backslash for win32.
> >
> > c:/go/src/package/runtime to c:\go\src\package\runtime
> 
> Not sure if this is a good idea. Does c:\go\src\package\runtime still
> match "c:/go/src/package/*"?
> 
> --Benny.

[bsiegert, 2011-02-04 10:21:27]

On Fri, Feb 4, 2011 at 11:12,  <mattn.jp@gmail.com> wrote:
>> Not sure if this is a good idea. Does c:\go\src\package\runtime still
>> match "c:/go/src/package/*"?
>
> Argument of Match is not path. it's patter. We shouldn't treat pattern
> as path.

I always have the following case in mind: you write a program that
accepts file name arguments, and the user gives you "C:\*" as an arg.
On Unix, the shell expands this for you, on Windows you have to call
path.Glob (which uses path.Match internally). How do you treat the
user input? Do you replace backslashes by slashes?

[mattn, 2011-02-04 10:29:02]

Yes, I guess that we should escape user's input.
For example of perl, to search text with user input from a file,
 We should escape the word and pass to regular expression.

   $text =~ /\Q$text\E/



On 2011/02/04 10:21:27, bsiegert wrote:
> On Fri, Feb 4, 2011 at 11:12,  <mailto:mattn.jp@gmail.com> wrote:
> >> Not sure if this is a good idea. Does c:\go\src\package\runtime still
> >> match "c:/go/src/package/*"?
> >
> > Argument of Match is not path. it's patter. We shouldn't treat pattern
> > as path.
> 
> I always have the following case in mind: you write a program that
> accepts file name arguments, and the user gives you "C:\*" as an arg.
> On Unix, the shell expands this for you, on Windows you have to call
> path.Glob (which uses path.Match internally). How do you treat the
> user input? Do you replace backslashes by slashes?

[mattn, 2011-02-04 11:27:27]

Hello golang-dev@googlegroups.com, bsiegert, r, rsc (cc:
golang-dev@googlegroups.com),

Please take another look.

[mattn, 2011-02-04 11:29:02]

http://codereview.appspot.com/3989064/diff/16001/src/pkg/path/path_test.go
File src/pkg/path/path_test.go (right):

http://codereview.appspot.com/3989064/diff/16001/src/pkg/path/path_test.go#ne...
src/pkg/path/path_test.go:267: if os.Getuid() > 0 {
win32 return -1 always.

[mattn, 2011-02-04 11:29:47]

http://codereview.appspot.com/3989064/diff/16001/src/pkg/path/path_test.go
File src/pkg/path/path_test.go (right):

http://codereview.appspot.com/3989064/diff/16001/src/pkg/path/path_test.go#ne...
src/pkg/path/path_test.go:267: if os.Getuid() > 0 {
On 2011/02/04 11:29:02, mattn wrote:
> win32 return -1 always.

Done.

[rsc, 2011-02-04 14:39:01]

I appreciate all the effort here but until the design
question in issue 1423 gets resolved, it's all premature.
As I said yesterday, I'd like to think about what we want
package path to mean before we just start making changes.

Russ

[bsiegert, 2011-02-07 14:26:14]

On Mon, Feb 7, 2011 at 01:16, mattn <mattn.jp@gmail.com> wrote:
> Is this issue a problem discussing which is better to be slash and backslash?

How about adding a function to path in order to change the default separator?

--Benny.

[brainman, 2011-02-07 23:36:29]

On 2011/02/04 06:30:52, mattn wrote:
> Hello mailto:golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> http://go.googlecode.com/hg/

Please, note http://code.google.com/p/go/issues/detail?id=1483.

Perhaps, you should add "Fixes issue 1483." at the end of your CL description,
if you're planning to resolve it.

Alex

[r2, 2011-02-08 00:03:05]

On Feb 7, 2011, at 3:57 PM, mattn wrote:

> ok, I added "fix issue 1107, 1423, 1483".
> 
> On Tuesday, February 8, 2011 8:36:29 AM UTC+9, brainman wrote:
> On 2011/02/04 06:30:52, mattn wrote:
> > Hello mailto:golan...@googlegroups.com,
> > I'd like you to review this change to
> > http://go.googlecode.com/hg/
> 
> Please, note http://code.google.com/p/go/issues/detail?id=1483.
> 
> Perhaps, you should add "Fixes issue 1483." at the end of your CL
> description, if you're planning to resolve it.

You need to write it the way the tools expect.

Fixes issue 1483.
Fixes issue 1107.
Fixes issue 1423.

-rob

[rsc, 2011-02-09 04:57:36]

I am a bit unhappy about all this path hacking
going on without a clear understanding of what
the API should be.  Issue 1423 is about deciding
an API, not implementing code.

It sounds like everyone thinks that package path
should be an OS-specific package.  I might as well
go along, since path.Walk has set the precedent.

But before we just toss in every function you can
think of, I would like to see some discussion via email
to golang-dev, not via looking at code on the codereview
server, of what the final API is going to be.
Right now it feels like a midden heap of Windows artifacts.

Russ

[rsc, 2011-02-09 06:15:52]

I am okay with making package path use \ on Windows.
But I want to see a list of the functions we're going to put
in package path first, in an email discussion, before we
start looking at coding details.  There are too many and
more every day.

Russ

[bsiegert, 2011-02-09 07:07:46]

On Wed, Feb 9, 2011 at 07:15, Russ Cox <rsc@golang.org> wrote:
> I am okay with making package path use \ on Windows.
> But I want to see a list of the functions we're going to put
> in package path first, in an email discussion, before we
> start looking at coding details.  There are too many and
> more every day.

I proposed a long time ago to loosely follow the well-established API
of File::Spec in Perl. The nice thing about this API is its symmetry
-- the functions operating on paths have a corresponding reverse
function. Comparing File::Spec, to path, we have:

canonpath - similar to path.Clean
catdir, catfile, join - path.Join (I figure that the separation in the
Perl functions is needed on VMS)
splitdir - path.Split (but see below)
curdir, rootdir, updir - I don't think we need these
file_name_is_absolute - path.IsAbs
tmpdir, devnull - in other packages in Go

splitpath - path.Split. However, splitpath returns *three* values:
"Splits a path in to volume, directory, and filename portions. On
systems with no concept of volume, returns '' for volume."

For symmetry, there is also catpath: "Takes volume, directory and file
portions and returns an entire path. Under Unix, $volume is ignored,
and directory and file are concatenated. A '/' is inserted if need be.
On other OSes, $volume is significant."

Then, there are two functions that would be very useful IMHO:

abs2rel: Takes a destination path and an optional base path returns a
relative path from the base path to the destination path.

rel2abs: Converts a relative path to an absolute path.

The following two might also be interesting to have:

case_tolerant: Returns a true or false value indicating, respectively,
that alphabetic case is not or is significant when comparing file
specifications.

no_upwards: Given a list of file names, strip out those that refer to
a parent directory.

--Benny.

[mattn, 2011-02-10 00:42:46]

Hello golang-dev@googlegroups.com, bsiegert, r, rsc, brainman, r2 (cc:
golang-dev@googlegroups.com),

Please take another look.

[mattn, 2011-02-10 00:43:36]

I fixed a problem of Clean() on windows.

  Clean("C:/") returned "C:"

On 2011/02/10 00:42:46, mattn wrote:
> Hello mailto:golang-dev@googlegroups.com, bsiegert, r, rsc, brainman, r2 (cc:
> mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

[mattn, 2011-02-10 00:52:18]

Ah, sorry.
I found problem.
Please wait.

On 2011/02/10 00:43:36, mattn wrote:
> I fixed a problem of Clean() on windows.
> 
>   Clean("C:/") returned "C:"
> 
> On 2011/02/10 00:42:46, mattn wrote:
> > Hello mailto:golang-dev@googlegroups.com, bsiegert, r, rsc, brainman, r2
(cc:
> > mailto:golang-dev@googlegroups.com),
> > 
> > Please take another look.

[mattn, 2011-02-10 01:02:06]

Hello golang-dev@googlegroups.com, bsiegert, r, rsc, brainman, r2 (cc:
golang-dev@googlegroups.com),

Please take another look.

[mattn, 2011-02-10 01:04:17]

I changed:

* renamed IsSame to isSame
  This is not needed for go user.
* fixed problem that Clean("C:/") return "C:"

On 2011/02/10 01:02:06, mattn wrote:
> Hello mailto:golang-dev@googlegroups.com, bsiegert, r, rsc, brainman, r2 (cc:
> mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

[mattn, 2011-02-10 01:24:51]

Hello golang-dev@googlegroups.com, bsiegert, r, rsc, brainman, r2 (cc:
golang-dev@googlegroups.com),

Please take another look.

[brainman, 2011-02-11 00:16:23]

On 2011/02/10 01:24:51, mattn wrote:
> Hello mailto:golang-dev@googlegroups.com, bsiegert, r, rsc, brainman, r2 (cc:
> mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

You're claiming this CL fixes these issues:

Fixes issue 1483.
Fixes issue 1107.
Fixes issue 1423.

But I don't think either 1483 or 1423 are fixed. After your patch this program:

package main
import (
  "path"
  "fmt"
)
func main() {
        fmt.Println(path.Join("directory", "file"))
        println(path.IsAbs("C:\\hello.txt"))
}

prints this:

directory/file
false

Regardless, I think, you should always try and include reported issues to the
package tests, if possible.

Alex

[mattn, 2011-02-15 01:53:27]

Rally? I get following.

directory\file
true

On 2011/02/11 00:16:23, brainman wrote:
> On 2011/02/10 01:24:51, mattn wrote:
> > Hello mailto:golang-dev@googlegroups.com, bsiegert, r, rsc, brainman, r2
(cc:
> > mailto:golang-dev@googlegroups.com),
> > 
> > Please take another look.
> 
> You're claiming this CL fixes these issues:
> 
> Fixes issue 1483.
> Fixes issue 1107.
> Fixes issue 1423.
> 
> But I don't think either 1483 or 1423 are fixed. After your patch this
program:
> 
> package main
> import (
>   "path"
>   "fmt"
> )
> func main() {
>         fmt.Println(path.Join("directory", "file"))
>         println(path.IsAbs("C:\\hello.txt"))
> }
> 
> prints this:
> 
> directory/file
> false
> 
> Regardless, I think, you should always try and include reported issues to the
> package tests, if possible.
> 
> Alex

[brainman, 2011-02-16 05:02:31]

On 2011/02/15 01:53:27, mattn wrote:
> Rally? I get following.
> 
> directory\file
> true
> 

You're right, I'm wrong. It works.

LGTM.

http://codereview.appspot.com/3989064/diff/38001/src/pkg/path/path_test.go
File src/pkg/path/path_test.go (right):

http://codereview.appspot.com/3989064/diff/38001/src/pkg/path/path_test.go#ne...
src/pkg/path/path_test.go:332: 
Please, add test for above mentioned

path.Join("directory", "file")

and

path.IsAbs("C:\\hello.txt")

http://codereview.appspot.com/3989064/diff/38001/src/pkg/path/path_unix.go
File src/pkg/path/path_unix.go (right):

http://codereview.appspot.com/3989064/diff/38001/src/pkg/path/path_unix.go#ne...
src/pkg/path/path_unix.go:6: 
import "strings"

[mattn, 2011-02-16 08:06:43]

Hello golang-dev@googlegroups.com, bsiegert, r, rsc, brainman, r2 (cc:
golang-dev@googlegroups.com),

Please take another look.

[mattn, 2011-02-16 08:06:55]

http://codereview.appspot.com/3989064/diff/38001/src/pkg/path/path_test.go
File src/pkg/path/path_test.go (right):

http://codereview.appspot.com/3989064/diff/38001/src/pkg/path/path_test.go#ne...
src/pkg/path/path_test.go:332: 
On 2011/02/16 05:02:31, brainman wrote:
> Please, add test for above mentioned
> 
> path.Join("directory", "file")
> 
> and
> 
> path.IsAbs("C:\\hello.txt")

Done.

http://codereview.appspot.com/3989064/diff/38001/src/pkg/path/path_unix.go
File src/pkg/path/path_unix.go (right):

http://codereview.appspot.com/3989064/diff/38001/src/pkg/path/path_unix.go#ne...
src/pkg/path/path_unix.go:6: 
On 2011/02/16 05:02:31, brainman wrote:
> import "strings"

Done.

[rsc, 2011-02-16 16:25:48]

Work on this CL is not a productive use of time.
I want time to design the path story first.

Russ

[mattn, 2011-03-09 05:56:54]

I created new CL, then i'll close this issue.

http://codereview.appspot.com/4249064/

On 2011/02/16 16:25:48, rsc wrote:
> Work on this CL is not a productive use of time.
> I want time to design the path story first.
> 
> Russ

[mattn, 2011-03-09 06:03:14]

*** Abandoned ***