Issue 3989060: Overwrite Gtk+'s default compose table to fix crosbug.com/11421.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3989060: Overwrite Gtk+'s default compose table to fix crosbug.com/11421. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by Yusuke Sato

Modified:
13 years, 3 months ago

Reviewers:
Peng, Peng Huang, satorux

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Overwrite Gtk+'s default compose table to fix crosbug.com/11421. BUG=chromium-os:11421 TEST=manually done on Chrome OS.

Patch Set 1 #

Patch Set 2 : review #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
	M	client/gtk2/ibusimcontext.c	View	1	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Yusuke Sato

This is for chromeos branch of ibus. ...and I'm wondering if there's a way to ...

13 years, 3 months ago (2011-02-02 08:50:52 UTC) #2

Peng

On 2011/02/02 08:50:52, Yusuke Sato wrote: > This is for chromeos branch of ibus. > ...

13 years, 3 months ago (2011-02-02 14:46:43 UTC) #3

Yusuke Sato

13 years, 3 months ago (2011-02-02 14:50:25 UTC) #4

Oh i see. I'll submit it to master tomorrow morning.

-Yusuke

On Wed, Feb 2, 2011 at 11:46 PM, <Shawn.P.Huang@gmail.com> wrote:

> On 2011/02/02 08:50:52, Yusuke Sato wrote:
>
>> This is for chromeos branch of ibus.
>>
>
>  ...and I'm wondering if there's a way to make it possible to upstream
>>
> this
>
>> patch...
>>
>
> LGTM. I am not sure if it is best behavior for all users, but I think we
> could submit it to mast at first, and wait for some feedbacks.
>
>
>
>
> http://codereview.appspot.com/3989060/
>

Expand All Messages | Collapse All Messages