Issue 3981050: Allow variable names with length of up to 256 characters (this is required by...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3981050: Allow variable names with length of up to 256 characters (this is required by... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by zmo

Modified:
13 years, 3 months ago

Reviewers:
gmangoog, gmanchromium

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Allow variable names with length of up to 256 characters (this is required by WebGL spec). BUG=109 TEST=the 256-character variable test in glsl-conformance.html passes Committed: http://code.google.com/p/angleproject/source/detail?r=552

Patch Set 1 #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/compiler/preprocessor/scanner.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

gmanchromium

13 years, 3 months ago (2011-01-31 23:39:33 UTC) #2

lgtm

BTW, the fact that this code has a MAX_STRING_LEN has issues. I added a test to
glsl-conformance.html to show the issue. We need to either fix the code or
update the spec IMO.

Expand All Messages | Collapse All Messages