Issue 3975043: code review 3975043: Sync from internal version.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3975043: code review 3975043: Sync from internal version. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by dsymonds

Modified:
14 years, 10 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

Sync from internal version. This is the support for the "public import" feature.

Patch Set 1 #

Patch Set 2 : code review 3975043: Sync from internal version. #

Patch Set 3 : code review 3975043: Sync from internal version. #

Patch Set 4 : code review 3975043: Sync from internal version. #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+128 lines, -25 lines)			Patch
M	compiler/generator/generator.go	View	11 chunks	+119 lines, -25 lines	0 comments	Download
M	compiler/testdata/imp.proto	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	compiler/testdata/test.pb.go.golden	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	proto/testdata/test.pb.go	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dsymonds

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 10 months ago (2011-01-20 05:11:23 UTC) #1

Why do you want to push this out now? Just to get it over with? ...

14 years, 10 months ago (2011-01-20 05:28:08 UTC) #2

dsymonds

On Thu, Jan 20, 2011 at 4:28 PM, Rob 'Commander' Pike <r@golang.org> wrote: > Why ...

14 years, 10 months ago (2011-01-20 05:30:24 UTC) #3

dsymonds

14 years, 10 months ago (2011-01-20 07:33:27 UTC) #5

*** Submitted as e090cf2de892 ***

	Sync from internal version.
        This is the support for the "public import" feature.

R=r
CC=golang-dev
http://codereview.appspot.com/3975043

Expand All Messages | Collapse All Messages