Issue 3975042: Do not handle release key events, if engine is in init mode.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3975042: Do not handle release key events, if engine is in init mode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by Peng

Modified:
13 years, 8 months ago

Reviewers:
Yusuke Sato

CC:
satorux, suzhe

Base URL:
git@github.com:ibus/ibus-pinyin.git@master

Visibility:
Public.

Description

Do not handle release key events, if engine is in init mode. Most application only process key press events, but some process key release events. This change will let Pinyin engine to ignore some release events in init mode, and let applications have chance to get release key events. BUG=none TEST=Test within Ubuntu 10.10

Patch Set 1 #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -2 lines)			Patch
	M	src/PYBopomofoEngine.cc	View		1 chunk	+11 lines, -1 line	0 comments	Download
	M	src/PYPinyinEngine.cc	View		1 chunk	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Yusuke Sato

13 years, 8 months ago (2011-01-18 14:23:31 UTC) #2

Sorry for the delay, LGTM.

Would be nice if you could write why the change was needed in the patch
description.

Expand All Messages | Collapse All Messages