Issue 3973053: Improve usability of SkAdvancedTypefaceMetrics for non PDF cases.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3973053: Improve usability of SkAdvancedTypefaceMetrics for non PDF cases. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by Steve VanDeBogart

Modified:
13 years, 5 months ago

Reviewers:
bsalomon, evan

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Improve usability of SkAdvancedTypefaceMetrics for non PDF cases. Change the code to fill out the metrics even if the font isn't embeddable. Previously, if the font wasn't embeddable, the code would set the type to not embeddable and return without filling out the rest of the metrics. Committed: http://code.google.com/p/skia/source/detail?r=758

Patch Set 1 #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -10 lines)			Patch
	M	src/ports/SkFontHost_FreeType.cpp	View		4 chunks	+6 lines, -10 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

evan

I don't understand the change (I lack context) but I can at least ask: can ...

13 years, 5 months ago (2011-02-03 17:43:54 UTC) #3

Steve VanDeBogart

On 2011/02/03 17:43:54, evan wrote: > I don't understand the change (I lack context) but ...

13 years, 5 months ago (2011-02-03 17:57:34 UTC) #4

bsalomon

13 years, 5 months ago (2011-02-03 21:47:03 UTC) #5

LGTM

I don't fully understand the context but it is fairly straight-forward and looks
like it does what the description says.

On 2011/02/03 17:57:34, Steve VanDeBogart wrote:
> On 2011/02/03 17:43:54, evan wrote:
> > I don't understand the change (I lack context) but I can at least ask: can
you
> > make the change description describe what you're changing?
> 
> Done.

Expand All Messages | Collapse All Messages