Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4212)

Issue 3973053: Improve usability of SkAdvancedTypefaceMetrics for non PDF cases. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by Steve VanDeBogart
Modified:
13 years, 9 months ago
Reviewers:
bsalomon, evan
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Improve usability of SkAdvancedTypefaceMetrics for non PDF cases. Change the code to fill out the metrics even if the font isn't embeddable. Previously, if the font wasn't embeddable, the code would set the type to not embeddable and return without filling out the rest of the metrics. Committed: http://code.google.com/p/skia/source/detail?r=758

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 4 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 5
Steve VanDeBogart
13 years, 9 months ago (2011-02-03 00:43:02 UTC) #1
Steve VanDeBogart
13 years, 9 months ago (2011-02-03 17:30:40 UTC) #2
evan
I don't understand the change (I lack context) but I can at least ask: can ...
13 years, 9 months ago (2011-02-03 17:43:54 UTC) #3
Steve VanDeBogart
On 2011/02/03 17:43:54, evan wrote: > I don't understand the change (I lack context) but ...
13 years, 9 months ago (2011-02-03 17:57:34 UTC) #4
bsalomon
13 years, 9 months ago (2011-02-03 21:47:03 UTC) #5
LGTM

I don't fully understand the context but it is fairly straight-forward and looks
like it does what the description says.

On 2011/02/03 17:57:34, Steve VanDeBogart wrote:
> On 2011/02/03 17:43:54, evan wrote:
> > I don't understand the change (I lack context) but I can at least ask: can
you
> > make the change description describe what you're changing?
> 
> Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b