Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(811)

Issue 38720043: font: rewrite accidental code (sharp and natural)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by janek
Modified:
10 years, 4 months ago
Reviewers:
wl, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

font: rewrite accidental code (sharp and natural) contains 2 commits: font: parametrize and cleanup sharp code Changes: * as much as possible is controlled by global parameters, * variables have more consistent names, * the functions are more consistently structured, * stem ends are placed in one line using explicit beam direction. The glyphs remain identical. It would be good to extract one global procedure that would draw all needed sharps (instead of having 6 similar ones), but i didn't have enough time to do this. font: rewrite and parametrize natural code The logic remains virtually the same. List of changes: * more descriptive variable names, * removed surplus points (1', 3', 11', 21'), * stem brushing is controlled in a simpler way, * beam slant does no longer depend on stem thickness, * all dimensions are explicitely and straightforwardly derived from global parameters. This makes it trivial to get a differently-looking natural by just changing clearly defined values. At size 20, the natural remains identical. At signifincantly different sizes there are a few microscopic changes, but they are too small to be noticeable: * stem end thickness is defined in terms of stem thickness, so regardless of design size the ratio between them is constant. * beam slant is slightly more consistent. But you wouldn't notice the change if i haven't told you ;-)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -248 lines) Patch
M mf/feta-accidentals/naturals.mf View 2 chunks +94 lines, -81 lines 0 comments Download
M mf/feta-accidentals/sharps.mf View 5 chunks +152 lines, -167 lines 0 comments Download

Messages

Total messages: 1
janek
10 years, 4 months ago (2013-12-07 09:31:06 UTC) #1
Please review my changes to accidentals metafont code.

A warning: this patch applies to https://codereview.appspot.com/38530043/ (not
master).

See it on branch dev/janek/metafont-accidentals-rewrite

thanks,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b