Issue 3858044: Remove a gcc warning.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3858044: Remove a gcc warning. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by Yusuke Sato

Modified:
13 years, 5 months ago

Reviewers:
shawn.p.huang, Peng Huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Remove a gcc warning. ibusxml.c: In function 'ibus_xml_parse_file': ibusxml.c:213: error: 'retval' may be used uninitialized in this function BUG=none TEST=ran make CFLAGS="-Wall -O2"

Patch Set 1 #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/ibusxml.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Yusuke Sato

BTW, the "-Wall -Werror" flags specified in autogen.sh are not working correctly?

13 years, 5 months ago (2011-01-12 06:33:53 UTC) #1

Peng

On 2011/01/12 06:33:53, Yusuke Sato wrote: > BTW, the "-Wall -Werror" flags specified in autogen.sh ...

13 years, 5 months ago (2011-01-12 13:27:59 UTC) #2

Yusuke Sato

13 years, 5 months ago (2011-01-12 13:37:31 UTC) #3

hmm.. I tried './autogen.sh ; make' but the warning was not shown. I have to
call make CFLAGS="-Wall -O2" explicitly to get the warning.

I'll take a look at the issue in detail later.

On 2011/01/12 13:27:59, Shawn.P.Huang wrote:
> On 2011/01/12 06:33:53, Yusuke Sato wrote:
> > BTW, the "-Wall -Werror" flags specified in autogen.sh are not working
> > correctly?
> 
> It should work. Actually, autoget.sh will call ./configure with CFLAGS='...',
if
> you run ./configure by self, the cflags will be overwritten.
> 
> LGTM

Expand All Messages | Collapse All Messages