Issue 3836042: Create an instance of GDBusProxy with G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES flag.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3836042: Create an instance of GDBusProxy with G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES flag. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Yusuke Sato

Modified:
13 years, 6 months ago

Reviewers:
shawn.p.huang, Peng Huang

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Create an instance of GDBusProxy with G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES flag. Without the flag, on_name_owner_changed() in glib-2.26.x/gio/gdbusproxy.c might invoke a remote method named GetAll in org.freedesktop.DBus.Properties interface, but the method is not implemented in ibus-daemon. Since ibus-daemon ignores the method call, the caller, which is UI thread of Chrome on Chromium OS, will block for 25 seconds (i.e. the default timeout of GDBus) waiting for a reply. BUG=none TEST=manually

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/ibusconfig.c	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/ibusinputcontext.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

LGTM. BTW, I think if remote objects do not support properties related methods, they should ...

13 years, 6 months ago (2010-12-26 17:44:01 UTC) #2

Yusuke Sato

13 years, 6 months ago (2010-12-26 22:33:50 UTC) #3

thx. FYI, currently the GetAll method call is filtered by
g_return_val_if_reached(NULL) call here:
https://github.com/ibus/ibus/blob/master/bus/dbusimpl.c#L887

On 2010/12/26 17:44:01, Shawn.P.Huang wrote:
> LGTM. BTW, I think if remote objects do not support properties related
methods,
> they should reply an error instead doing nothing. I will check it.
> 
> On 2010/12/26 17:08:13, Yusuke Sato wrote:

Expand All Messages | Collapse All Messages