No complaints? I'll go ahead and push it in 24 hours if nobody objects or ...
14 years, 3 months ago
(2011-01-04 05:48:27 UTC)
#2
No complaints? I'll go ahead and push it in 24 hours if nobody objects or asks
for more time.
(you don't need to have any specific objections; if you're busy and can't review
it for the next few days, but want to review it, just let me know and I'll wait)
On 2011/01/01 00:47:54, Graham Percival wrote: > Please review. LGTM, apart a nitpick: I prefer ...
14 years, 3 months ago
(2011-01-04 09:58:46 UTC)
#4
On 2011/01/01 00:47:54, Graham Percival wrote:
> Please review.
LGTM, apart a nitpick: I prefer to create build directory outside git tree, i.e.
if foo/lily is my git repo, I build in foo/build, to avoid build/ appear to git
as an untracked file.
On Tue, Jan 04, 2011 at 09:58:46AM +0000, john.mandereau@gmail.com wrote: > LGTM, apart a nitpick: ...
14 years, 3 months ago
(2011-01-04 10:35:26 UTC)
#5
On Tue, Jan 04, 2011 at 09:58:46AM +0000, john.mandereau@gmail.com wrote:
> LGTM, apart a nitpick: I prefer to create build directory outside git
> tree, i.e. if foo/lily is my git repo, I build in foo/build, to avoid
> build/ appear to git as an untracked file.
Check .gitignore. :)
I personally have also been doing a truly "out-of-tree" build
until recently, but I became concerned that unix newbies might not
like having a ~/lilypond-build/ in addition to ~/lilypond-git/.
I decided that putting build/ inside the source tree -- which is
actually the default in waf and cmake, for example -- was easier
to explain and understand for new contributors.
Cheers,
- Graham
Il giorno mar, 04/01/2011 alle 10.35 +0000, Graham Percival ha scritto: > On Tue, Jan ...
14 years, 3 months ago
(2011-01-04 10:40:06 UTC)
#6
Il giorno mar, 04/01/2011 alle 10.35 +0000, Graham Percival ha scritto:
> On Tue, Jan 04, 2011 at 09:58:46AM +0000, john.mandereau@gmail.com wrote:
> > LGTM, apart a nitpick: I prefer to create build directory outside git
> > tree, i.e. if foo/lily is my git repo, I build in foo/build, to avoid
> > build/ appear to git as an untracked file.
>
> Check .gitignore. :)
Fine :)
> I personally have also been doing a truly "out-of-tree" build
> until recently, but I became concerned that unix newbies might not
> like having a ~/lilypond-build/ in addition to ~/lilypond-git/.
> I decided that putting build/ inside the source tree -- which is
> actually the default in waf and cmake, for example -- was easier
> to explain and understand for new contributors.
Agreed.
Cheers,
John
Issue 3823045: CG: out-of-tree building in main compile chapter.
(Closed)
Created 14 years, 3 months ago by Graham Percival (old account)
Modified 14 years, 3 months ago
Reviewers: Trevor Daniels, John Mandereau, Graham Percival
Base URL:
Comments: 0