Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(329)

Issue 3821042: code review 3821042: Added "clean" target to make commands run by goinstall

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by Kyle E. Lemons
Modified:
13 years, 2 months ago
Reviewers:
adg, rsc
CC:
adg, rsc, golang-dev
Visibility:
Public.

Description

Added "clean" target to make commands run by goinstall This is primarily an issue when updating a go source tree to the newest version of go when goinstall has already compiled libraries. The binaries are not recompiled, but instead are simply reinstalled when goinstall attempts to install them again. This causes the code to be rebuilt from scratch each time goinstall runs.

Patch Set 1 #

Patch Set 2 : code review 3821042: Added "clean" target to make commands run by goinstall #

Patch Set 3 : code review 3821042: Added "clean" target to make commands run by goinstall #

Total comments: 1

Patch Set 4 : code review 3821042: Added "clean" target to make commands run by goinstall #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M src/cmd/goinstall/main.go View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/goinstall/make.go View 1 2 3 1 chunk +15 lines, -6 lines 0 comments Download

Messages

Total messages: 9
Kyle E. Lemons
Hello adg, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 3 months ago (2010-12-24 03:04:16 UTC) #1
adg
LGTM, but I'll wait for rsc's opinion. On 24 December 2010 14:04, <kyle@kylelemons.net> wrote: > ...
13 years, 3 months ago (2010-12-28 03:04:56 UTC) #2
adg
13 years, 2 months ago (2011-01-04 04:32:15 UTC) #3
rsc
I don't think this is okay. It makes builds slower by unnecessarily installing packages over ...
13 years, 2 months ago (2011-01-04 12:08:57 UTC) #4
Kyle E. Lemons
PTAL. I have changed it to have a -clean flag that causes the "clean" target ...
13 years, 2 months ago (2011-01-05 00:05:08 UTC) #5
rsc
http://codereview.appspot.com/3821042/diff/9001/src/cmd/goinstall/make.go File src/cmd/goinstall/make.go (right): http://codereview.appspot.com/3821042/diff/9001/src/cmd/goinstall/make.go#newcode21 src/cmd/goinstall/make.go:21: // If we need standard input, put it here ...
13 years, 2 months ago (2011-01-05 18:20:03 UTC) #6
Kyle E. Lemons
PTAL. Of course, I can no longer claim credit for the code ;-). But it ...
13 years, 2 months ago (2011-01-05 18:29:19 UTC) #7
rsc
LGTM If you're happy I'm happy.
13 years, 2 months ago (2011-01-05 19:27:18 UTC) #8
rsc
13 years, 2 months ago (2011-01-05 19:35:00 UTC) #9
*** Submitted as d51abca4c978 ***

goinstall: add -clean flag

R=adg, rsc
CC=golang-dev
http://codereview.appspot.com/3821042

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b