Issue 3807047: Support enable/disable hotkeys

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3807047: Support enable/disable hotkeys (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by Yusuke Sato

Modified:
13 years, 9 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Support enable/disable hotkeys that enable or disable ibus unconditionally (i.e. not toggle.) I'll update ibus/po/*po files if the change looks good to you. BUG=http://code.google.com/p/ibus/issues/detail?id=1173 TEST=manually

Patch Set 1 : rebase #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+195 lines, -33 lines)			Patch
M	bus/ibusimpl.c	View	5 chunks	+54 lines, -8 lines	0 comments	Download
M	ibus/common.py	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	setup/main.py	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	setup/setup.ui	View	5 chunks	+115 lines, -19 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Yusuke Sato

Hi, Would it be possible to review this change? The change is not related to ...

13 years, 10 months ago (2011-01-30 13:44:13 UTC) #1

Peng

13 years, 9 months ago (2011-02-10 20:42:00 UTC) #2

On 2011/01/30 13:44:13, Yusuke Sato wrote:
> Hi,
> Would it be possible to review this change?
> 
> The change is not related to Chromium OS at all :), but very important for
> Japanese keyboard users.

LGTM. Sorry for reply late.

Expand All Messages | Collapse All Messages