Issue 3807042: Port FUSE bindings to Go release.2010-12-15.1.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3807042: Port FUSE bindings to Go release.2010-12-15.1. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by hanwen-google

Modified:
12 years, 8 months ago

Reviewers:
imkrasin, krasin

CC:
krasin

Base URL:
git://github.com/krasin/go-fuse-zip.git@master

Visibility:
Public.

Description

Port FUSE bindings to Go release.2010-12-15.1. * Make it 64-bit clean. * Make tests resilient against NFS root squashing.

Patch Set 1 #

Patch Set 2 : Apply gofmt #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -83 lines)			Patch
M	fuse/fuse.go	View	1	6 chunks	+24 lines, -23 lines	0 comments	Download
M	fuse/fuse_test.go	View	1	5 chunks	+25 lines, -12 lines	0 comments	Download
M	fuse/mount.go	View	1	6 chunks	+46 lines, -48 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

krasin

LGTM Please, run gofmt on this CL to keep the formatting canonical.

14 years, 2 months ago (2010-12-21 16:52:42 UTC) #1

hanwen-google

Done. On Tue, Dec 21, 2010 at 2:52 PM, <krasin@google.com> wrote: > LGTM > > ...

14 years, 2 months ago (2010-12-21 17:05:08 UTC) #2

imkrasin

Committed: https://github.com/krasin/go-fuse-zip/commit/da579c85fa7896c9b780801042d0236b08ddd548 On 2010/12/21 17:05:08, hanwen wrote: > Done. > > On Tue, Dec 21, ...

14 years, 2 months ago (2010-12-21 17:20:31 UTC) #3

hanwen-google

14 years, 2 months ago (2010-12-21 17:35:33 UTC) #4

Great, thanks.

On Tue, Dec 21, 2010 at 3:20 PM,  <imkrasin@gmail.com> wrote:
> Committed:
>
https://github.com/krasin/go-fuse-zip/commit/da579c85fa7896c9b780801042d0236b...
>
> On 2010/12/21 17:05:08, hanwen wrote:
>>
>> Done.
>
>> On Tue, Dec 21, 2010 at 2:52 PM,  <mailto:krasin@google.com> wrote:
>> > LGTM
>> >
>> > Please, run gofmt on this CL to keep the formatting canonical.
>> >
>> > http://codereview.appspot.com/3807042/
>> >
>
>
>
>> --
>> Han-Wen Nienhuys
>> Google Engineering Belo Horizonte
>> mailto:hanwen@google.com
>
>
>
> http://codereview.appspot.com/3807042/
>



-- 
Han-Wen Nienhuys
Google Engineering Belo Horizonte
hanwen@google.com

Expand All Messages | Collapse All Messages