Fix for loading L/LA images into a native (8/16-bit) D3D surface.

Fix for loading L/LA images into a native (8/16-bit) D3D surface.

Fixed in r523.

[dgkoch, 2010-12-23 03:54:41]

Ooops :-0

LGTM
Btw you might want to add yourself to the CONTRIBUTORS file..

[baustin, 2011-01-04 22:18:31]

Do I need to do anything more before submitting this code?  I tried to submit
using "gcl commit ia_subtex_fix", but get the following error:

Running presubmit hooks...
Loaded authentication cookies from N:\data\home_dir/.codereview_upload_cookies
Authentication realm: <https://angleproject.googlecode.com:443> Google Code
Subversion Repository
Password for 'baustin': ...
svn: Commit failed (details follow):
svn: Server sent unexpected return value (500 Internal Server Error) in response
to MKACTIVITY request for '/svn/!svn/act/...

On 2010/12/23 03:54:41, dgkoch wrote:
> Ooops :-0
> 
> LGTM
> Btw you might want to add yourself to the CONTRIBUTORS file..

To add myself, do I just edit the file and send it out for review?

thanks,
Brent

[vangelis, 2011-01-04 23:09:14]

Hi Brent,
  I think the problem was that you weren't in the list of committers.  I've
added you now.  Can you please give it another shot?

Thanks,
Vangelis


On Tue, Jan 4, 2011 at 2:18 PM, <baustin@google.com> wrote:

> Do I need to do anything more before submitting this code?  I tried to
> submit using "gcl commit ia_subtex_fix", but get the following error:
>
> Running presubmit hooks...
> Loaded authentication cookies from
> N:\data\home_dir/.codereview_upload_cookies
> Authentication realm: <https://angleproject.googlecode.com:443> Google
> Code Subversion Repository
> Password for 'baustin': ...
> svn: Commit failed (details follow):
> svn: Server sent unexpected return value (500 Internal Server Error) in
> response to MKACTIVITY request for '/svn/!svn/act/...
>
> On 2010/12/23 03:54:41, dgkoch wrote:
>
>> Ooops :-0
>>
>
>  LGTM
>> Btw you might want to add yourself to the CONTRIBUTORS file..
>>
>
> To add myself, do I just edit the file and send it out for review?
>
> thanks,
> Brent
>
>
> http://codereview.appspot.com/3805044/
>

[dgkoch, 2011-01-05 04:12:31]

On 2011-01-04, at 5:18 PM, baustin@google.com wrote:

>> 
>> LGTM
>> Btw you might want to add yourself to the CONTRIBUTORS file..
> 
> To add myself, do I just edit the file and send it out for review?

Yes, that should do it.

Daniel

---
                        Daniel Koch -+- daniel@transgaming.com
Senior Graphics Architect -+- TransGaming Inc.  -+- www.transgaming.com

[baustin, 2011-01-05 18:52:03]

Thanks for adding me, but it doesn't seem to have helped.  I'm still getting the
same error as before.

I think something is going wrong with gcl authentication.  I think gcl is trying
to submit with the username "baustin", instead of "baustin@google.com".  If I
delete my .codereview_upload_cookies file, I will be prompted twice for my
password.  The first time looks like it succeeds to authenticate and the prompt
shows "baustin@google.com".  The second time shows only "baustin", and appears
to fail:

/cygdrive/n/angle_dev/trunk/src> gcl commit ia_subtex_fix
Running presubmit hooks...
Email (login for uploading to codereview.appspot.com) [baustin@google.com]:
baustin@google.com
Password for baustin@google.com:
Saving authentication cookies to N:\data\home_dir/.codereview_upload_cookies
Authentication realm: <https://angleproject.googlecode.com:443> Google Code
Subversion Repository
Password for 'baustin':
svn: Commit failed (details follow):
svn: Server sent unexpected return value (500 Internal Server Error) in response
to MKACTIVITY request for


Also, the prompt for the (second) password doesn't show up until after I enter
something (the script appears to hang after the "Authentication realm:..." line.
 The "Password for baustin:" prompt doesn't show up until I press enter.

Any ideas?  I'm going to try getting a new version of devtools, but I think I
already have the most recent version.

thanks,
Brent


On 2011/01/04 23:09:14, vangelis wrote:
> Hi Brent,
>   I think the problem was that you weren't in the list of committers.  I've
> added you now.  Can you please give it another shot?
> 
> Thanks,
> Vangelis
> 
> 
> On Tue, Jan 4, 2011 at 2:18 PM, <mailto:baustin@google.com> wrote:
> 
> > Do I need to do anything more before submitting this code?  I tried to
> > submit using "gcl commit ia_subtex_fix", but get the following error:
> >
> > Running presubmit hooks...
> > Loaded authentication cookies from
> > N:\data\home_dir/.codereview_upload_cookies
> > Authentication realm: <https://angleproject.googlecode.com:443> Google
> > Code Subversion Repository
> > Password for 'baustin': ...
> > svn: Commit failed (details follow):
> > svn: Server sent unexpected return value (500 Internal Server Error) in
> > response to MKACTIVITY request for '/svn/!svn/act/...
> >
> > On 2010/12/23 03:54:41, dgkoch wrote:
> >
> >> Ooops :-0
> >>
> >
> >  LGTM
> >> Btw you might want to add yourself to the CONTRIBUTORS file..
> >>
> >
> > To add myself, do I just edit the file and send it out for review?
> >
> > thanks,
> > Brent
> >
> >
> > http://codereview.appspot.com/3805044/
> >

[kbr1, 2011-01-05 19:06:37]

On Wed, Jan 5, 2011 at 10:52 AM,  <baustin@google.com> wrote:
> Thanks for adding me, but it doesn't seem to have helped.  I'm still
> getting the same error as before.
>
> I think something is going wrong with gcl authentication.  I think gcl
> is trying to submit with the username "baustin", instead of
> "baustin@google.com".  If I delete my .codereview_upload_cookies file, I
> will be prompted twice for my password.  The first time looks like it
> succeeds to authenticate and the prompt shows "baustin@google.com".  The
> second time shows only "baustin", and appears to fail:
>
> /cygdrive/n/angle_dev/trunk/src> gcl commit ia_subtex_fix
> Running presubmit hooks...
> Email (login for uploading to codereview.appspot.com)
> [baustin@google.com]: baustin@google.com
> Password for baustin@google.com:
> Saving authentication cookies to
> N:\data\home_dir/.codereview_upload_cookies
> Authentication realm: <https://angleproject.googlecode.com:443> Google
> Code Subversion Repository
> Password for 'baustin':
> svn: Commit failed (details follow):
> svn: Server sent unexpected return value (500 Internal Server Error) in
> response to MKACTIVITY request for
>
>
> Also, the prompt for the (second) password doesn't show up until after I
> enter something (the script appears to hang after the "Authentication
> realm:..." line.  The "Password for baustin:" prompt doesn't show up
> until I press enter.
>
> Any ideas?  I'm going to try getting a new version of devtools, but I
> think I already have the most recent version.

I frequently need to hit return when gcl prompts me for "Password for
kbr:" in order to be able to enter my full email address (kbr at
chromium.org).

Also, I never run gcl from a cygwin prompt, only a raw command prompt
with only the depot_tools binaries on $PATH. Not sure whether cygwin's
binaries (python version, etc.) might be interfering with gcl's proper
operation.

-Ken

> thanks,
> Brent
>
>
> On 2011/01/04 23:09:14, vangelis wrote:
>>
>> Hi Brent,
>>   I think the problem was that you weren't in the list of committers.
>
> I've
>>
>> added you now.  Can you please give it another shot?
>
>> Thanks,
>> Vangelis
>
>
>> On Tue, Jan 4, 2011 at 2:18 PM, <mailto:baustin@google.com> wrote:
>
>> > Do I need to do anything more before submitting this code?  I tried
>
> to
>>
>> > submit using "gcl commit ia_subtex_fix", but get the following
>
> error:
>>
>> >
>> > Running presubmit hooks...
>> > Loaded authentication cookies from
>> > N:\data\home_dir/.codereview_upload_cookies
>> > Authentication realm: <https://angleproject.googlecode.com:443>
>
> Google
>>
>> > Code Subversion Repository
>> > Password for 'baustin': ...
>> > svn: Commit failed (details follow):
>> > svn: Server sent unexpected return value (500 Internal Server Error)
>
> in
>>
>> > response to MKACTIVITY request for '/svn/!svn/act/...
>> >
>> > On 2010/12/23 03:54:41, dgkoch wrote:
>> >
>> >> Ooops :-0
>> >>
>> >
>> >  LGTM
>> >> Btw you might want to add yourself to the CONTRIBUTORS file..
>> >>
>> >
>> > To add myself, do I just edit the file and send it out for review?
>> >
>> > thanks,
>> > Brent
>> >
>> >
>> > http://codereview.appspot.com/3805044/
>> >
>
>
>
> https://codereview.appspot.com/3805044/
>

[baustin, 2011-01-05 21:28:06]

On 2011/01/05 19:06:37, kbr1 wrote:
> I frequently need to hit return when gcl prompts me for "Password for
> kbr:" in order to be able to enter my full email address (kbr at
> http://chromium.org).

Pressing return just gives me the error without a chance to change the account.

> 
> Also, I never run gcl from a cygwin prompt, only a raw command prompt
> with only the depot_tools binaries on $PATH. Not sure whether cygwin's
> binaries (python version, etc.) might be interfering with gcl's proper
> operation.

I just tried this, but it didn't help.  I've also tried 32 and 64-bit versions
of cmd, getting a clean checkout of depot_tools, and various options for gcl
(--no_cookies, --no_presubmit, and --user baustin@google.com).

I'll keep digging.

Brent

[vangelis, 2011-01-05 21:32:24]

On Wed, Jan 5, 2011 at 1:28 PM, <baustin@google.com> wrote:

> On 2011/01/05 19:06:37, kbr1 wrote:
>
>> I frequently need to hit return when gcl prompts me for "Password for
>> kbr:" in order to be able to enter my full email address (kbr at
>> http://chromium.org).
>>
>
> Pressing return just gives me the error without a chance to change the
> account.


If it looks like the shell is waiting for you to enter text and when you're
typing you actually see what you type, then it's expecting your email.  If
you type blindly, it's expecting a password.  Those are the clues I use.  I
agree though that this is all very annoying.  If all else fails, just do a
regular svn checkin and manually update the issue.


>
>
>  Also, I never run gcl from a cygwin prompt, only a raw command prompt
>> with only the depot_tools binaries on $PATH. Not sure whether cygwin's
>> binaries (python version, etc.) might be interfering with gcl's proper
>> operation.
>>
>
> I just tried this, but it didn't help.  I've also tried 32 and 64-bit
> versions of cmd, getting a clean checkout of depot_tools, and various
> options for gcl (--no_cookies, --no_presubmit, and --user
> baustin@google.com).
>
> I'll keep digging.
>
> Brent
>
>
> https://codereview.appspot.com/3805044/
>

[baustin, 2011-01-06 18:43:13]

On 2011/01/05 21:32:24, vangelis wrote:
> On Wed, Jan 5, 2011 at 1:28 PM, <mailto:baustin@google.com> wrote:
> 
> > On 2011/01/05 19:06:37, kbr1 wrote:
> >
> >> I frequently need to hit return when gcl prompts me for "Password for
> >> kbr:" in order to be able to enter my full email address (kbr at
> >> http://chromium.org).
> >>
> >
> > Pressing return just gives me the error without a chance to change the
> > account.
> 
> 
> If it looks like the shell is waiting for you to enter text and when you're
> typing you actually see what you type, then it's expecting your email.  If
> you type blindly, it's expecting a password.  Those are the clues I use.  I
> agree though that this is all very annoying.  If all else fails, just do a
> regular svn checkin and manually update the issue.
> 
> 

Sorry for all the questions, but I still can't get this to work.  I tried using
svn directly, but got the same errors.  I also tried on another machine and with
tortoise svn, but got the same error all the time.  My only guess now is that
there is something wrong with my account or with the permissions for my account.
 Does the authentication ever require CAPTCH or OTP?  I'm assuming that the
username/password for SVN authentication is the same as for my domain account. 
Is this ever not the case?

Anyway, I can't spend much more time debugging this.  Can someone check in this
patch and the patches in issue #3733043 and #3772045 for me?

thanks,
Brent

[vangelis, 2011-01-06 20:17:25]

On Thu, Jan 6, 2011 at 10:43 AM, <baustin@google.com> wrote:

> On 2011/01/05 21:32:24, vangelis wrote:
>
>  On Wed, Jan 5, 2011 at 1:28 PM, <mailto:baustin@google.com> wrote:
>>
>
>  > On 2011/01/05 19:06:37, kbr1 wrote:
>> >
>> >> I frequently need to hit return when gcl prompts me for "Password
>>
> for
>
>> >> kbr:" in order to be able to enter my full email address (kbr at
>> >> http://chromium.org).
>> >>
>> >
>> > Pressing return just gives me the error without a chance to change
>>
> the
>
>> > account.
>>
>
>
>  If it looks like the shell is waiting for you to enter text and when
>>
> you're
>
>> typing you actually see what you type, then it's expecting your email.
>>
>  If
>
>> you type blindly, it's expecting a password.  Those are the clues I
>>
> use.  I
>
>> agree though that this is all very annoying.  If all else fails, just
>>
> do a
>
>> regular svn checkin and manually update the issue.
>>
>
>
>
> Sorry for all the questions, but I still can't get this to work.  I
> tried using svn directly, but got the same errors.  I also tried on
> another machine and with tortoise svn, but got the same error all the
> time.  My only guess now is that there is something wrong with my
> account or with the permissions for my account.  Does the authentication
> ever require CAPTCH or OTP?  I'm assuming that the username/password for
> SVN authentication is the same as for my domain account.  Is this ever
> not the case?
>

Aha! When checking in via svn you should be using your svn password which
you'll get when you go to:

https://code.google.com/hosting/settings

<https://code.google.com/hosting/settings>(you can get there via the
"Profile" link on the upper right corner of all the codesite pages, once
you're authenticated)

Sorry for the time waste...

Vangelis


>
> Anyway, I can't spend much more time debugging this.  Can someone check
> in this patch and the patches in issue #3733043 and #3772045 for me?
>
> thanks,
>
> Brent
>
>
> https://codereview.appspot.com/3805044/
>

[baustin, 2011-01-06 21:29:43]

Yes, that helps!  I was able to submit using tortoise SVN.  gcl still
gives the same error, so I'll just stick with tortoise for now.

When I submit using SVN, what should I update in the issue?  Mark it
as closed and put the SVN revision #?

Brent


On Thu, Jan 6, 2011 at 12:17 PM, Vangelis Kokkevis <vangelis@google.com> wrote:
>
>
> On Thu, Jan 6, 2011 at 10:43 AM, <baustin@google.com> wrote:
>>
>> On 2011/01/05 21:32:24, vangelis wrote:
>>>
>>> On Wed, Jan 5, 2011 at 1:28 PM, <mailto:baustin@google.com> wrote:
>>
>>> > On 2011/01/05 19:06:37, kbr1 wrote:
>>> >
>>> >> I frequently need to hit return when gcl prompts me for "Password
>>
>> for
>>>
>>> >> kbr:" in order to be able to enter my full email address (kbr at
>>> >> http://chromium.org).
>>> >>
>>> >
>>> > Pressing return just gives me the error without a chance to change
>>
>> the
>>>
>>> > account.
>>
>>
>>> If it looks like the shell is waiting for you to enter text and when
>>
>> you're
>>>
>>> typing you actually see what you type, then it's expecting your email.
>>
>>  If
>>>
>>> you type blindly, it's expecting a password.  Those are the clues I
>>
>> use.  I
>>>
>>> agree though that this is all very annoying.  If all else fails, just
>>
>> do a
>>>
>>> regular svn checkin and manually update the issue.
>>
>>
>>
>> Sorry for all the questions, but I still can't get this to work.  I
>> tried using svn directly, but got the same errors.  I also tried on
>> another machine and with tortoise svn, but got the same error all the
>> time.  My only guess now is that there is something wrong with my
>> account or with the permissions for my account.  Does the authentication
>> ever require CAPTCH or OTP?  I'm assuming that the username/password for
>> SVN authentication is the same as for my domain account.  Is this ever
>> not the case?
>
> Aha! When checking in via svn you should be using your svn password which
> you'll get when you go to:
> https://code.google.com/hosting/settings
> (you can get there via the "Profile" link on the upper right corner of all
> the codesite pages, once you're authenticated)
> Sorry for the time waste...
> Vangelis
>
>>
>> Anyway, I can't spend much more time debugging this.  Can someone check
>> in this patch and the patches in issue #3733043 and #3772045 for me?
>>
>> thanks,
>> Brent
>>
>>
>> https://codereview.appspot.com/3805044/
>
>

[vangelis, 2011-01-06 21:51:27]

On Thu, Jan 6, 2011 at 1:29 PM, Brent Austin <baustin@google.com> wrote:

> Yes, that helps!  I was able to submit using tortoise SVN.  gcl still
> gives the same error, so I'll just stick with tortoise for now.
>
> When I submit using SVN, what should I update in the issue?  Mark it
> as closed and put the SVN revision #?
>

Great!  Yes, marking it closed and adding the svn revision would be good.

Vangelis


>
> Brent
>
>
> On Thu, Jan 6, 2011 at 12:17 PM, Vangelis Kokkevis <vangelis@google.com>
> wrote:
> >
> >
> > On Thu, Jan 6, 2011 at 10:43 AM, <baustin@google.com> wrote:
> >>
> >> On 2011/01/05 21:32:24, vangelis wrote:
> >>>
> >>> On Wed, Jan 5, 2011 at 1:28 PM, <mailto:baustin@google.com> wrote:
> >>
> >>> > On 2011/01/05 19:06:37, kbr1 wrote:
> >>> >
> >>> >> I frequently need to hit return when gcl prompts me for "Password
> >>
> >> for
> >>>
> >>> >> kbr:" in order to be able to enter my full email address (kbr at
> >>> >> http://chromium.org).
> >>> >>
> >>> >
> >>> > Pressing return just gives me the error without a chance to change
> >>
> >> the
> >>>
> >>> > account.
> >>
> >>
> >>> If it looks like the shell is waiting for you to enter text and when
> >>
> >> you're
> >>>
> >>> typing you actually see what you type, then it's expecting your email.
> >>
> >>  If
> >>>
> >>> you type blindly, it's expecting a password.  Those are the clues I
> >>
> >> use.  I
> >>>
> >>> agree though that this is all very annoying.  If all else fails, just
> >>
> >> do a
> >>>
> >>> regular svn checkin and manually update the issue.
> >>
> >>
> >>
> >> Sorry for all the questions, but I still can't get this to work.  I
> >> tried using svn directly, but got the same errors.  I also tried on
> >> another machine and with tortoise svn, but got the same error all the
> >> time.  My only guess now is that there is something wrong with my
> >> account or with the permissions for my account.  Does the authentication
> >> ever require CAPTCH or OTP?  I'm assuming that the username/password for
> >> SVN authentication is the same as for my domain account.  Is this ever
> >> not the case?
> >
> > Aha! When checking in via svn you should be using your svn password which
> > you'll get when you go to:
> > https://code.google.com/hosting/settings
> > (you can get there via the "Profile" link on the upper right corner of
> all
> > the codesite pages, once you're authenticated)
> > Sorry for the time waste...
> > Vangelis
> >
> >>
> >> Anyway, I can't spend much more time debugging this.  Can someone check
> >> in this patch and the patches in issue #3733043 and #3772045 for me?
> >>
> >> thanks,
> >> Brent
> >>
> >>
> >> https://codereview.appspot.com/3805044/
> >
> >
>