Issue 3802042: Add comments to ibusproxy.[ch] and related functions.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3802042: Add comments to ibusproxy.[ch] and related functions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Yusuke Sato

Modified:
13 years, 6 months ago

Reviewers:
shawn.p.huang, Peng Huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Add comments to ibusproxy.[ch] and related functions. BUG=none TEST=none

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -2 lines)			Patch
M	bus/ibusimpl.c	View	4 chunks	+14 lines, -2 lines	0 comments	Download
M	src/ibusproxy.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/ibusproxy.c	View	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Yusuke Sato

Let me add some comments to the proxy class since it's a bit hard for ...

13 years, 6 months ago (2010-12-20 13:42:50 UTC) #1

Peng

13 years, 6 months ago (2010-12-20 15:10:23 UTC) #2

On 2010/12/20 13:42:50, Yusuke Sato wrote:
> Let me add some comments to the proxy class since it's a bit hard for me to
> understand how the special dispose function, ibus_proxy_destroy(), works.

LGTM

Expand All Messages | Collapse All Messages