Set the "g-default-timeout" property for ibusconfig, ibusinputcontext, and ibusbus objects.

Set the "g-default-timeout" property for ibusconfig, ibusinputcontext, and ibusbus objects. The GDBus default timeout (25 seconds) seems to be too long for IBus.

BUG=none
TEST=manually, with IBUS_BUS_TIMEOUT=-3,-2,-1,0,1,1000,6000,abc,1abc,abc1

[Peng, 2011-01-05 17:32:23]

http://codereview.appspot.com/3799049/diff/1/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/3799049/diff/1/src/ibusbus.c#newcode915
src/ibusbus.c:915: 6000, /* timeout in ms. the default timeout on the
ibus-daemon side (5 sec) + 1 sec. */
I suggest using a macro or a variable to control the timeout. And it is better
if it could be set with an environ value in runtime.

http://codereview.appspot.com/3799049/diff/1/src/ibusconfig.c
File src/ibusconfig.c (right):

http://codereview.appspot.com/3799049/diff/1/src/ibusconfig.c#newcode149
src/ibusconfig.c:149: "g-default-timeout", 5000,
Why use 5000? But it is 6000 in other place.

[Yusuke Sato, 2011-01-06 04:36:25]

please take another look

http://codereview.appspot.com/3799049/diff/1/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/3799049/diff/1/src/ibusbus.c#newcode915
src/ibusbus.c:915: 6000, /* timeout in ms. the default timeout on the
ibus-daemon side (5 sec) + 1 sec. */
On 2011/01/05 17:32:23, Shawn.P.Huang wrote:
> I suggest using a macro or a variable to control the timeout. And it is better
> if it could be set with an environ value in runtime.

Done.

http://codereview.appspot.com/3799049/diff/1/src/ibusconfig.c
File src/ibusconfig.c (right):

http://codereview.appspot.com/3799049/diff/1/src/ibusconfig.c#newcode149
src/ibusconfig.c:149: "g-default-timeout", 5000,
Fixed, thx

[Peng, 2011-01-06 15:51:30]

http://codereview.appspot.com/3799049/diff/6001/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/3799049/diff/6001/src/ibusbus.c#newcode915
src/ibusbus.c:915: ibus_get_bus_timeout(),
I would like add space between function name and '('.

http://codereview.appspot.com/3799049/diff/6001/src/ibusconfig.c
File src/ibusconfig.c (right):

http://codereview.appspot.com/3799049/diff/6001/src/ibusconfig.c#newcode149
src/ibusconfig.c:149: "g-default-timeout", ibus_get_bus_timeout(),
The same style issue.

http://codereview.appspot.com/3799049/diff/6001/src/ibusinputcontext.c
File src/ibusinputcontext.c (right):

http://codereview.appspot.com/3799049/diff/6001/src/ibusinputcontext.c#newcod...
src/ibusinputcontext.c:662: "g-default-timeout", ibus_get_bus_timeout(),
same.

http://codereview.appspot.com/3799049/diff/6001/src/ibusshare.c
File src/ibusshare.c (right):

http://codereview.appspot.com/3799049/diff/6001/src/ibusshare.c#newcode205
src/ibusshare.c:205: const gchar *timeout_str = g_getenv ("IBUS_BUS_TIMEOUT");
Do you think IBUS_TIMEOUT is better? What's the mean of BUS_TIMEOUT?

[Yusuke Sato, 2011-01-06 16:06:07]

thx, fixed all.

http://codereview.appspot.com/3799049/diff/6001/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/3799049/diff/6001/src/ibusbus.c#newcode915
src/ibusbus.c:915: ibus_get_bus_timeout(),
On 2011/01/06 15:51:30, Shawn.P.Huang wrote:
> I would like add space between function name and '('.

Done.

http://codereview.appspot.com/3799049/diff/6001/src/ibusconfig.c
File src/ibusconfig.c (right):

http://codereview.appspot.com/3799049/diff/6001/src/ibusconfig.c#newcode149
src/ibusconfig.c:149: "g-default-timeout", ibus_get_bus_timeout(),
On 2011/01/06 15:51:30, Shawn.P.Huang wrote:
> The same style issue.

Done.

http://codereview.appspot.com/3799049/diff/6001/src/ibusinputcontext.c
File src/ibusinputcontext.c (right):

http://codereview.appspot.com/3799049/diff/6001/src/ibusinputcontext.c#newcod...
src/ibusinputcontext.c:662: "g-default-timeout", ibus_get_bus_timeout(),
On 2011/01/06 15:51:30, Shawn.P.Huang wrote:
> same.

Done.

http://codereview.appspot.com/3799049/diff/6001/src/ibusshare.c
File src/ibusshare.c (right):

http://codereview.appspot.com/3799049/diff/6001/src/ibusshare.c#newcode205
src/ibusshare.c:205: const gchar *timeout_str = g_getenv ("IBUS_BUS_TIMEOUT");
I'm fine with IBUS_TIMEOUT. Fixed.

On 2011/01/06 15:51:30, Shawn.P.Huang wrote:
> Do you think IBUS_TIMEOUT is better? What's the mean of BUS_TIMEOUT?

[Peng, 2011-01-06 16:34:07]

LGTM. Thx