Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2347)

Issue 37950044: Adds outside-staff-interface and outside-staff-axis-group-interface

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by MikeSol
Modified:
10 years, 4 months ago
Reviewers:
dak, mike7, Trevor Daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Adds outside-staff-interface and outside-staff-axis-group-interface When a property exists in an interface, the property should make sense for a sensible of grobs that implement that interface. Otherwise, the property should be part of a separate interface that applies to a sensibly-sized group of grobs. Various properties having to do with outside-staff calculations belong to grob-interface. This does not make sense for many grobs (StaffSpacing, NoteSpacing, SpacingSpanner, StaffSymbol just to name a few). There is a limited collection of grobs for which outside-staff properties make sense. The outside-staff-interface provides a separate interface to be implemented by these grobs. The same is true for axis groups that place outside-staff grobs, which form a limited subset of grobs implementing the axis-group-interface. Rather than putting the relevant properties in the axis-group-interface, we move them to an outside-staff-axis-group-interface.

Patch Set 1 #

Patch Set 2 : Adds outside-staff-interface to ChordName #

Patch Set 3 : Gives outside-staff-interface to several other grobs #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -10 lines) Patch
M input/regression/scheme-text-spanner.ly View 1 chunk +1 line, -0 lines 0 comments Download
M lily/axis-group-interface.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M lily/grob.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M scm/define-grob-interfaces.scm View 1 chunk +10 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 43 chunks +52 lines, -5 lines 4 comments Download

Messages

Total messages: 9
dak
The summary seems incompatible with <URL:http://music.stackexchange.com/a/14160/8773> Once an interface is required for outside-staffing a grob, ...
10 years, 4 months ago (2013-12-16 09:45:34 UTC) #1
Trevor Daniels
I applaud this! Properties in an interface which were not honoured when processing certain grobs ...
10 years, 4 months ago (2013-12-16 09:56:44 UTC) #2
mike7
On Dec 16, 2013, at 11:45 AM, dak@gnu.org wrote: > The summary seems incompatible with ...
10 years, 4 months ago (2013-12-16 09:58:40 UTC) #3
mike7
On Dec 16, 2013, at 11:56 AM, tdanielsmusic@googlemail.com wrote: > I applaud this! Properties in ...
10 years, 4 months ago (2013-12-16 09:58:55 UTC) #4
dak
On 2013/12/16 09:58:40, mike7 wrote: > On Dec 16, 2013, at 11:45 AM, mailto:dak@gnu.org wrote: ...
10 years, 4 months ago (2013-12-16 10:07:34 UTC) #5
mike7
On Dec 16, 2013, at 12:07 PM, dak@gnu.org wrote: > On 2013/12/16 09:58:40, mike7 wrote: ...
10 years, 4 months ago (2013-12-16 10:13:14 UTC) #6
MikeSol
Adds outside-staff-interface to ChordName
10 years, 4 months ago (2013-12-16 13:02:33 UTC) #7
MikeSol
Gives outside-staff-interface to several other grobs
10 years, 4 months ago (2013-12-21 12:47:59 UTC) #8
dak
10 years, 4 months ago (2013-12-25 22:07:41 UTC) #9
Spacing problems.  Nothing requiring to prolong the review, but should be fixed
before pushing.

https://codereview.appspot.com/37950044/diff/40001/scm/define-grobs.scm
File scm/define-grobs.scm (right):

https://codereview.appspot.com/37950044/diff/40001/scm/define-grobs.scm#newco...
scm/define-grobs.scm:355: outside-staff-axis-group-interface))))))
Don't use tabs in Scheme files.  Incidentally, this whole file only contained a
single tab previous to this patch, and that single tab is
0c849c547 scm/define-grobs.scm     (Mike Solomon       2013-08-27 08:44:23 +0300
 171) 	(cross-staff . ,ly:arpeggio::calc-cross-staff)

It's probably sufficient to run scripts/auxiliar/fixscm.sh on the file before
committing, but it's not clear that this will not affect other lines.

https://codereview.appspot.com/37950044/diff/40001/scm/define-grobs.scm#newco...
scm/define-grobs.scm:1984: slur-interface))))))
Tabs again.

https://codereview.appspot.com/37950044/diff/40001/scm/define-grobs.scm#newco...
scm/define-grobs.scm:2295: outside-staff-axis-group-interface))))))
Tabs again

https://codereview.appspot.com/37950044/diff/40001/scm/define-grobs.scm#newco...
scm/define-grobs.scm:2734: outside-staff-axis-group-interface))))))
More tabs.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b