Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(80)

Issue 37900043: Adds Python samples for the AdSense Management API v1.4 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by jalc
Modified:
11 years, 4 months ago
Reviewers:
jcgregorio_google
CC:
google-api-python-client_googlegroups.com
Base URL:
https://code.google.com/p/google-api-python-client/
Visibility:
Public.

Description

Adds Python samples for the AdSense Management API v1.4

Patch Set 1 #

Total comments: 4

Patch Set 2 : Cleaning pdb leftovers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -45 lines) Patch
M samples/adsense/generate_report.py View 2 chunks +5 lines, -1 line 0 comments Download
M samples/adsense/generate_report_with_paging.py View 2 chunks +4 lines, -3 lines 0 comments Download
M samples/adsense/get_account_tree.py View 2 chunks +5 lines, -4 lines 0 comments Download
M samples/adsense/get_all_accounts.py View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/adsense/get_all_ad_clients.py View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/adsense/get_all_ad_clients_for_account.py View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/adsense/get_all_ad_units.py View 2 chunks +3 lines, -2 lines 0 comments Download
M samples/adsense/get_all_ad_units_for_custom_channel.py View 2 chunks +7 lines, -4 lines 0 comments Download
M samples/adsense/get_all_alerts.py View 3 chunks +5 lines, -4 lines 0 comments Download
M samples/adsense/get_all_custom_channels.py View 3 chunks +3 lines, -3 lines 0 comments Download
M samples/adsense/get_all_custom_channels_for_ad_unit.py View 1 chunk +1 line, -1 line 0 comments Download
M samples/adsense/get_all_dimensions.py View 2 chunks +2 lines, -3 lines 0 comments Download
M samples/adsense/get_all_metrics.py View 2 chunks +2 lines, -3 lines 0 comments Download
A samples/adsense/get_all_payments.py View 1 1 chunk +55 lines, -0 lines 0 comments Download
M samples/adsense/get_all_saved_ad_styles.py View 2 chunks +3 lines, -4 lines 0 comments Download
M samples/adsense/get_all_saved_reports.py View 2 chunks +3 lines, -4 lines 0 comments Download
M samples/adsense/get_all_url_channels.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
jalc
New samples + some formatting nits that I found.
11 years, 7 months ago (2013-12-13 11:20:53 UTC) #1
jcgregorio_google
https://codereview.appspot.com/37900043/diff/1/samples/adsense/get_all_payments.py File samples/adsense/get_all_payments.py (right): https://codereview.appspot.com/37900043/diff/1/samples/adsense/get_all_payments.py#newcode28 samples/adsense/get_all_payments.py:28: import pdb Leftover debugging? https://codereview.appspot.com/37900043/diff/1/samples/adsense/get_all_payments.py#newcode38 samples/adsense/get_all_payments.py:38: pdb.set_trace() Leftover debugging?
11 years, 7 months ago (2013-12-16 15:14:46 UTC) #2
jalc
Good catch! https://codereview.appspot.com/37900043/diff/1/samples/adsense/get_all_payments.py File samples/adsense/get_all_payments.py (right): https://codereview.appspot.com/37900043/diff/1/samples/adsense/get_all_payments.py#newcode28 samples/adsense/get_all_payments.py:28: import pdb On 2013/12/16 15:14:46, jcgregorio_google wrote: ...
11 years, 7 months ago (2013-12-18 19:44:02 UTC) #3
jcgregorio_google
11 years, 7 months ago (2013-12-19 15:28:08 UTC) #4
On 2013/12/18 19:44:02, jalc wrote:
> Good catch!
> 
>
https://codereview.appspot.com/37900043/diff/1/samples/adsense/get_all_paymen...
> File samples/adsense/get_all_payments.py (right):
> 
>
https://codereview.appspot.com/37900043/diff/1/samples/adsense/get_all_paymen...
> samples/adsense/get_all_payments.py:28: import pdb
> On 2013/12/16 15:14:46, jcgregorio_google wrote:
> > Leftover debugging?
> 
> Done.
> 
>
https://codereview.appspot.com/37900043/diff/1/samples/adsense/get_all_paymen...
> samples/adsense/get_all_payments.py:38: pdb.set_trace()
> On 2013/12/16 15:14:46, jcgregorio_google wrote:
> > Leftover debugging?
> 
> Done.

lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b