Issue 3784047: Fix --timeout command line option of ibus-daemon.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3784047: Fix --timeout command line option of ibus-daemon. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by Yusuke Sato

Modified:
13 years, 5 months ago

Reviewers:
shawn.p.huang, Peng Huang

CC:
satorux

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Fix --timeout command line option of ibus-daemon. On 1.3.99, currently the option is just ignored and '-1' (i.e. the default timeout of gdbus which is 25 seconds in glib-2.26.1) is always used. We should fix this since the default, 25 secs, is too long for some platforms like Chromium OS. BUG=none TEST=manually

Patch Set 1 #

Patch Set 2 : review #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -20 lines)			Patch
M	bus/engineproxy.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	bus/engineproxy.c	View	1	4 chunks	+8 lines, -6 lines	0 comments	Download
M	bus/factoryproxy.c	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	bus/ibusimpl.c	View	1	3 chunks	+7 lines, -5 lines	0 comments	Download
M	bus/inputcontext.c	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	bus/main.c	View	1	3 chunks	+6 lines, -2 lines	0 comments	Download
M	bus/option.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	bus/panelproxy.c	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM. Thanks.

Expand All Messages | Collapse All Messages