Issue 3775042: Set correct sender and interface when sending org.freedesktop.IBus signals.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3775042: Set correct sender and interface when sending org.freedesktop.IBus signals. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Daiki Ueno

Modified:
13 years, 5 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Set correct sender and interface when sending org.freedesktop.IBus signals. BUG=none TEST=manual

Patch Set 1 #

Patch Set 2 : adjust GetNameOwner for the sender name change #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	bus/dbusimpl.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	bus/ibusimpl.c	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	bus/inputcontext.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Daiki Ueno

The Python binding expects that the sender of the IBus specific D-Bus signals is "org.freedesktop.IBus".

13 years, 6 months ago (2010-12-22 04:00:39 UTC) #1

Daiki Ueno

Sorry, the initial patch has a regression with the GTK+ client (I only tested it ...

13 years, 6 months ago (2010-12-24 08:33:35 UTC) #2

Daiki Ueno

Ping? Probably my explanation was unclear. Let me try again: (1) Currently, bus_input_context_emit_signal() sets the ...

13 years, 5 months ago (2011-01-06 08:12:25 UTC) #3

Peng

13 years, 5 months ago (2011-01-06 15:37:22 UTC) #4

On 2011/01/06 08:12:25, Daiki Ueno wrote:
> Ping?
> 
> Probably my explanation was unclear.  Let me try again:
> 
> (1) Currently, bus_input_context_emit_signal() sets the sender of signals to
> "org.freedesktop.DBus" not "org.freedesktop.IBus", unlike ibus 1.3.
> 
> (2) dbus-python's proxy implementation adds "sender='<bus_name>'" to the match
> rule, and ibus' python binding passes "org.freedesktop.IBus" as bus_name. 
Thus,
> the python binding cannot receive any signals.
> 
> (3) changing the sender in bus_input_context_emit_signal() not enough, since
> gdbusproxy.c:on_signal_received() checks the sender == name owner, and the
> current GetNameOwner implementation also hard-codes it to
> "org.freedesktop.DBus".
> 
> I confirmed that the second patch working well.  Actually the change to
> bus/ibusimpl.c is not necessary, but it's harmless and nice to use
> "org.freedesktop.IBus" there too, I think.
LGTM

Expand All Messages | Collapse All Messages