code review 3749041: os/signal: selective signal handling

src/pkg/os/exec_unix.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 // +build darwin freebsd linux netbsd openbsd
 
 package os
 
 import (
         "errors"
@@ skipping 39 matching lines @@
         w.WaitStatus = status
         w.Rusage = rusage
         return w, nil
 }
 
 // Signal sends a signal to the Process.
 func (p *Process) Signal(sig Signal) error {
         if p.done {
                 return errors.New("os: process already finished")
         }
-        if e := syscall.Kill(p.Pid, int(sig.(UnixSignal))); e != nil {
+        if e := syscall.Kill(p.Pid, sig.(syscall.Signal)); e != nil {

[bradfitz, 2012/02/09 00:23:35]

can we comma-ok assert the type and return an error rather than exploding here?

[rsc1, 2012/02/10 23:08:44]

Done.

                 return e
         }
         return nil
 }
 
 // Release releases any resources associated with the Process.
 func (p *Process) Release() error {
         // NOOP for unix.
         p.Pid = -1
         // no need for a finalizer anymore
         runtime.SetFinalizer(p, nil)
         return nil
 }
 
 func findProcess(pid int) (p *Process, err error) {
         // NOOP for unix.
         return newProcess(pid, 0), nil
 }