Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(388)

Issue 3669042: Fix perf regression in Color32 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 12 months ago by Stephen White
Modified:
13 years, 12 months ago
Reviewers:
agl
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The regression was due to the fact that we were calling PlatformColorProc() for every span (which in turns makes CPUID, a fairly expensive call). Since we draw a lot of rects, and rects have 1-pixel wide spans for the vertical segments, that's a lot of CPUID. Fixed by cacheing the result of PlatformColorProc(), as is done for the other platform-specific blitters.

Patch Set 1 #

Patch Set 2 : Remove opts_files.mk changes from this patch. #

Patch Set 3 : One more try.. fixing SkSrcOver_XfermodeColorFilter constructor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
Makefile View 1 chunk +1 line, -0 lines 0 comments Download
include/core/SkBlitRow.h View 1 chunk +3 lines, -11 lines 0 comments Download
src/core/SkBlitRow_D32.cpp View 1 chunk +6 lines, -7 lines 0 comments Download
src/core/SkBlitter_ARGB32.cpp View 4 chunks +5 lines, -3 lines 0 comments Download
src/core/SkCoreBlitters.h View 1 chunk +2 lines, -1 line 0 comments Download
src/effects/SkColorFilters.cpp View 1 2 4 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6
Stephen White
13 years, 12 months ago (2010-12-16 18:51:19 UTC) #1
Stephen White
Remove opts_files.mk changes from this patch.
13 years, 12 months ago (2010-12-16 18:53:50 UTC) #2
agl
LGTM
13 years, 12 months ago (2010-12-16 18:58:30 UTC) #3
Stephen White
One more try.. fixing SkSrcOver_XfermodeColorFilter constructor.
13 years, 12 months ago (2010-12-16 19:05:08 UTC) #4
agl
LGTM
13 years, 12 months ago (2010-12-16 19:16:20 UTC) #5
Stephen White
13 years, 12 months ago (2010-12-16 19:18:39 UTC) #6
Landed as r636.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b