Issue 3660041: Use unsigned for the parameter of the PropertyActivate message.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3660041: Use unsigned for the parameter of the PropertyActivate message. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Yusuke Sato

Modified:
13 years, 6 months ago

Reviewers:
shawn.p.huang, Peng Huang

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Use unsigned for the parameter of the PropertyActivate message. unsigned would be better since the Python binding and engine proxy use unsigned for this purpose. BUG=none TEST=ran Chrome for Chrome OS.

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	bus/inputcontext.c	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ibusinputcontext.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ibusinputcontext.c	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM. Thanks.

Expand All Messages | Collapse All Messages