Issue 365770043: Spanner::substitute_one_mutable_property: don't copy `this'

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 9 months ago by dak

Modified:
5 years, 9 months ago

Reviewers:
Dan Eble

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Spanner::substitute_one_mutable_property: don't copy `this' Also contains commit: break-substitution.cc: typo fix 'subsititution'

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -33 lines)			Patch
	M	lily/break-substitution.cc	View		3 chunks	+28 lines, -33 lines	0 comments	Download

Total messages: 1

Dan Eble

5 years, 9 months ago (2018-07-25 22:10:09 UTC) #1

To David: LGTM.

To whomever decided that lowercase L would be a good variable name: please,
never do it again.