Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5221)

Issue 365730043: Issue 5364: Simplify Drul_array indexing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by Dan Eble
Modified:
5 years, 9 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

... so that it is more obvious that the index is never out of bounds https://sourceforge.net/p/testlilyissues/issues/5364/ I thought that maybe the arithmetic was done for optimization purposes, but even if that was originally the case, Compiler Explorer shows simpler assembly from the simpler comparison: https://godbolt.org/g/cR1zVX

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M flower/include/drul-array.hh View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1
dak
5 years, 9 months ago (2018-07-01 12:18:52 UTC) #1
Well, you basically anticipated all considerations I could have brought up and
dealt with them exhaustively.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b