thread._local, threading.local Python issue 1868 & 3710

This is Amaury's patch from http://bugs.python.org/issue1868

[Antoine Pitrou]

http://codereview.appspot.com/3641/diff/1/2
File Modules/threadmodule.c (right):

http://codereview.appspot.com/3641/diff/1/2#newcode207
Line 207: if (PyDict_SetItem(tdict, self->key, localdict) < 0)
A Py_DECREF(localdict) is needed just before bailing out.

http://codereview.appspot.com/3641/diff/1/2#newcode300
Line 300: if (res < 0 && PyErr_ExceptionMatches(PyExc_AttributeError)) {
Why did you add this fallback? Is it really necessary?

[gregory.p.smith]

christian heimes updated version

[gregory.p.smith]

tamino's update of christian's (threading_local3)

[gregory.p.smith]

threading_local4 - includes the unit test, fixes the missing error path decref

[gregory.p.smith]

updated, please re-review.

http://codereview.appspot.com/3641/diff/1/2
File Modules/threadmodule.c (right):

http://codereview.appspot.com/3641/diff/1/2#newcode207
Line 207: if (PyDict_SetItem(tdict, self->key, localdict) < 0)
On 2008/08/28 09:29:49, Antoine Pitrou wrote:
> A Py_DECREF(localdict) is needed just before bailing out.
> 

Done.

http://codereview.appspot.com/3641/diff/1/2#newcode300
Line 300: if (res < 0 && PyErr_ExceptionMatches(PyExc_AttributeError)) {
On 2008/08/28 09:29:49, Antoine Pitrou wrote:
> Why did you add this fallback? Is it really necessary?
> 

this has been rewritten so that subclasses work.  please have another look.