Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1743)

Issue 363910043: Use "simple strings" rather than #"hash-prefixed Scheme strings" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by Valentin Villenave
Modified:
5 years, 1 month ago
Reviewers:
dak, thomasmorley651, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Use "simple strings" rather than #"hash-prefixed Scheme strings" Now that the user-exposed syntax hardly requires #-prefixed string arguments anymore, we can do away with that syntax through various places as well (particularly the LM, where it may make things slightly less confusing for newcomers). This commit leaves LSR-imported snippets untouched for now.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase & remove now moot paragraph in CG (Thanks Carl!). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1605 lines, -1614 lines) Patch
M Documentation/ca/learning/fundamental.itely View 18 chunks +19 lines, -19 lines 0 comments Download
M Documentation/ca/learning/tweaks.itely View 6 chunks +6 lines, -6 lines 0 comments Download
M Documentation/ca/notation/pitches.itely View 4 chunks +6 lines, -6 lines 0 comments Download
M Documentation/ca/notation/staff.itely View 18 chunks +30 lines, -30 lines 0 comments Download
M Documentation/contributor/doc-work.itexi View 1 2 chunks +1 line, -7 lines 0 comments Download
M Documentation/cs/learning/fundamental.itely View 18 chunks +19 lines, -19 lines 0 comments Download
M Documentation/cs/learning/tweaks.itely View 5 chunks +5 lines, -5 lines 0 comments Download
M Documentation/de/essay/engraving.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/de/learning/fundamental.itely View 18 chunks +19 lines, -19 lines 0 comments Download
M Documentation/de/learning/tweaks.itely View 6 chunks +6 lines, -6 lines 0 comments Download
M Documentation/de/notation/changing-defaults.itely View 4 chunks +5 lines, -5 lines 0 comments Download
M Documentation/de/notation/chords.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/de/notation/fretted-strings.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/de/notation/input.itely View 8 chunks +9 lines, -9 lines 0 comments Download
M Documentation/de/notation/percussion.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/de/notation/pitches.itely View 3 chunks +4 lines, -4 lines 0 comments Download
M Documentation/de/notation/spacing.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/de/notation/staff.itely View 18 chunks +25 lines, -25 lines 0 comments Download
M Documentation/de/notation/text.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/de/notation/vocal.itely View 9 chunks +12 lines, -12 lines 0 comments Download
M Documentation/es/changes.tely View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/es/essay/engraving.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/es/learning/fundamental.itely View 17 chunks +17 lines, -17 lines 0 comments Download
M Documentation/es/learning/tweaks.itely View 6 chunks +6 lines, -6 lines 0 comments Download
M Documentation/es/notation/ancient.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/notation/changing-defaults.itely View 5 chunks +7 lines, -7 lines 0 comments Download
M Documentation/es/notation/chords.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/es/notation/fretted-strings.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/es/notation/input.itely View 5 chunks +7 lines, -7 lines 0 comments Download
M Documentation/es/notation/percussion.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/es/notation/pitches.itely View 4 chunks +6 lines, -6 lines 0 comments Download
M Documentation/es/notation/spacing.itely View 1 chunk +4 lines, -4 lines 0 comments Download
M Documentation/es/notation/staff.itely View 17 chunks +27 lines, -27 lines 0 comments Download
M Documentation/es/notation/text.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/notation/vocal.itely View 6 chunks +9 lines, -9 lines 0 comments Download
M Documentation/essay/engraving.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/fr/changes.tely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/essay/engraving.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/fr/learning/fundamental.itely View 17 chunks +17 lines, -17 lines 0 comments Download
M Documentation/fr/learning/tweaks.itely View 6 chunks +6 lines, -6 lines 0 comments Download
M Documentation/fr/notation/ancient.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/notation/changing-defaults.itely View 5 chunks +7 lines, -7 lines 0 comments Download
M Documentation/fr/notation/chords.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/fr/notation/fretted-strings.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/fr/notation/input.itely View 5 chunks +7 lines, -7 lines 0 comments Download
M Documentation/fr/notation/percussion.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/fr/notation/pitches.itely View 4 chunks +6 lines, -6 lines 0 comments Download
M Documentation/fr/notation/spacing.itely View 1 chunk +4 lines, -4 lines 0 comments Download
M Documentation/fr/notation/staff.itely View 17 chunks +27 lines, -27 lines 0 comments Download
M Documentation/fr/notation/text.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/notation/vocal.itely View 6 chunks +9 lines, -9 lines 0 comments Download
M Documentation/hu/essay/engraving.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/hu/learning/fundamental.itely View 18 chunks +19 lines, -19 lines 0 comments Download
M Documentation/included/chord-names-languages.ly View 1 chunk +5 lines, -5 lines 0 comments Download
M Documentation/included/display-predefined-string-tunings.ly View 1 chunk +11 lines, -11 lines 0 comments Download
M Documentation/included/gonville.ly View 3 chunks +4 lines, -4 lines 0 comments Download
M Documentation/it/changes.tely View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/it/essay/engraving.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/it/learning/fundamental.itely View 18 chunks +19 lines, -19 lines 0 comments Download
M Documentation/it/learning/tweaks.itely View 6 chunks +6 lines, -6 lines 0 comments Download
M Documentation/it/notation/changing-defaults.itely View 5 chunks +7 lines, -7 lines 0 comments Download
M Documentation/it/notation/input.itely View 5 chunks +7 lines, -7 lines 0 comments Download
M Documentation/it/notation/pitches.itely View 4 chunks +6 lines, -6 lines 0 comments Download
M Documentation/it/notation/spacing.itely View 1 chunk +4 lines, -4 lines 0 comments Download
M Documentation/it/notation/staff.itely View 17 chunks +27 lines, -27 lines 0 comments Download
M Documentation/it/notation/text.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/it/notation/vocal.itely View 6 chunks +9 lines, -9 lines 0 comments Download
M Documentation/ja/learning/fundamental.itely View 18 chunks +19 lines, -19 lines 0 comments Download
M Documentation/ja/learning/tweaks.itely View 6 chunks +6 lines, -6 lines 0 comments Download
M Documentation/ja/notation/changing-defaults.itely View 5 chunks +7 lines, -7 lines 0 comments Download
M Documentation/ja/notation/chords.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ja/notation/fretted-strings.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/ja/notation/input.itely View 8 chunks +9 lines, -9 lines 0 comments Download
M Documentation/ja/notation/percussion.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/ja/notation/pitches.itely View 3 chunks +4 lines, -4 lines 0 comments Download
M Documentation/ja/notation/spacing.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/ja/notation/staff.itely View 18 chunks +25 lines, -25 lines 0 comments Download
M Documentation/ja/notation/text.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/vocal.itely View 9 chunks +12 lines, -12 lines 0 comments Download
M Documentation/learning/fundamental.itely View 17 chunks +17 lines, -17 lines 0 comments Download
M Documentation/learning/tweaks.itely View 7 chunks +10 lines, -13 lines 0 comments Download
M Documentation/ly-examples/cary.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ly-examples/tab-example.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/music-glossary.tely View 2 chunks +4 lines, -4 lines 0 comments Download
M Documentation/nl/learning/fundamental.itely View 18 chunks +19 lines, -19 lines 0 comments Download
M Documentation/nl/learning/tweaks.itely View 6 chunks +6 lines, -6 lines 0 comments Download
M Documentation/notation/ancient.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/notation/changing-defaults.itely View 5 chunks +7 lines, -7 lines 0 comments Download
M Documentation/notation/chords.itely View 1 1 chunk +1 line, -1 line 0 comments Download
M Documentation/notation/fretted-strings.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/notation/input.itely View 5 chunks +7 lines, -7 lines 0 comments Download
M Documentation/notation/pitches.itely View 4 chunks +6 lines, -6 lines 0 comments Download
M Documentation/notation/spacing.itely View 1 chunk +4 lines, -4 lines 0 comments Download
M Documentation/notation/staff.itely View 17 chunks +27 lines, -27 lines 0 comments Download
M Documentation/notation/text.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/notation/vocal.itely View 6 chunks +9 lines, -9 lines 0 comments Download
M Documentation/snippets/new/adding-drum-parts.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/new/combining-two-parts-on-the-same-staff.ly View 1 chunk +3 lines, -3 lines 0 comments Download
M Documentation/snippets/new/incipit.ly View 1 chunk +4 lines, -4 lines 0 comments Download
M Documentation/snippets/new/jazz-combo-template.ly View 1 chunk +10 lines, -10 lines 0 comments Download
M Documentation/snippets/new/orchestra,-choir-and-piano-template.ly View 3 chunks +14 lines, -14 lines 0 comments Download
M Documentation/snippets/new/piano-template-simple.ly View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/snippets/new/quoting-another-voice.ly View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/snippets/new/quoting-another-voice-with-transposition.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/snippets/new/replacing-default-midi-instrument-equalization.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/new/unfretted-headword.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/alignment-order.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/ambitus-cue.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/chord-additional-pitch-prefix.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/chord-name-override-text.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/chord-names-languages.ly View 2 chunks +6 lines, -6 lines 0 comments Download
M input/regression/chromatic-scales.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/clip-systems.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/cue-clef.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/cue-clef-after-barline.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/cue-clef-begin-of-score.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/cue-clef-keysignature.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/cue-clef-new-line.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/cue-clef-transposition.ly View 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/cue-clef-transposition-optional.ly View 1 chunk +4 lines, -4 lines 0 comments Download
M input/regression/dead-notes.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/display-lily-tests.ly View 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/double-repeat-default-volta.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/dynamics-context-textspan.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/filter-translators.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/font-name.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/fret-diagrams-fret-label.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/fret-diagrams-xo-label.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/id.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/incipit.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/instrument-name-groups.ly View 2 chunks +10 lines, -10 lines 0 comments Download
M input/regression/instrument-name-hara-kiri.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/instrument-name-pedal-lyrics.ly View 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/instrument-name-volta.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/instrument-switch.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/les-nereides.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/line-arrows.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/markup-eps.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/markup-rest.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/markup-syntax.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/markup-user.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/midi-volume-equaliser.ly View 2 chunks +13 lines, -13 lines 0 comments Download
M input/regression/mozart-hrn3-defs.ily View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/ottava.ly View 3 chunks +4 lines, -4 lines 0 comments Download
M input/regression/page-breaks.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/predefined-fretboards.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/property-nested-override.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/quote.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/quote-cue-during.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/quote-cyclic.ly View 1 chunk +3 lines, -3 lines 0 comments Download
M input/regression/quote-during.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/quote-during-subvoice.ly View 2 chunks +10 lines, -10 lines 0 comments Download
M input/regression/quote-grace.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/quote-kill-cues.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/quote-overrides.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/quote-transposition.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/quote-tuplet.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/quote-tuplet-end.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/repeat-percent-kerning.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-associated-voice.ly View 3 chunks +3 lines, -3 lines 0 comments Download
M input/regression/song-basic.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-basic-nonenglish.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-breathe.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-melisma.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-reordering.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-reordering2.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-repetition.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-skip.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-skip-noword.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-slurs.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-splitpart.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-stanzas.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/song-tempo.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/spacing-non-adjacent-columns3.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tag-filter.ly View 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/text-spanner.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M ly/engraver-init.ly View 10 chunks +15 lines, -15 lines 0 comments Download
M ly/festival.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M ly/grace-init.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M ly/performer-init.ly View 3 chunks +3 lines, -3 lines 0 comments Download
M ly/predefined-guitar-fretboards.ly View 24 chunks +87 lines, -87 lines 0 comments Download
M ly/predefined-guitar-ninth-fretboards.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M ly/predefined-mandolin-fretboards.ly View 1 chunk +204 lines, -204 lines 0 comments Download
M ly/predefined-ukulele-fretboards.ly View 1 chunk +306 lines, -306 lines 0 comments Download
M python/musicexp.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
Carl
Because this represents a change in the documentation policy as listed in the CG, I ...
5 years, 1 month ago (2019-02-10 18:41:33 UTC) #1
thomasmorley651
On 2019/02/10 18:41:33, Carl wrote: > Because this represents a change in the documentation policy ...
5 years, 1 month ago (2019-02-10 19:31:07 UTC) #2
dak
thomasmorley65@gmail.com writes: > On 2019/02/10 18:41:33, Carl wrote: >> Because this represents a change in ...
5 years, 1 month ago (2019-02-10 19:59:36 UTC) #3
Valentin Villenave
On 2019/02/10 19:59:36, dak wrote: > >> Simple strings -- don't need # > > ...
5 years, 1 month ago (2019-02-14 07:56:09 UTC) #4
Valentin Villenave
Rebase & remove now moot paragraph in CG (Thanks Carl!).
5 years, 1 month ago (2019-02-19 23:25:36 UTC) #5
Valentin Villenave
5 years, 1 month ago (2019-02-25 16:27:20 UTC) #6
On 2019/02/19 23:25:36, Valentin Villenave wrote:
> Rebase & remove now moot paragraph in CG (Thanks Carl!).

Pushed as
https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=ed86e71eb0f17e93036...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b