Issue 3585042: Fix bookpart identifier crash with page-marker.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3585042: Fix bookpart identifier crash with page-marker. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Neil Puttock

Modified:
13 years, 2 months ago

Reviewers:
joeneeman, carl.d.sorensen, Graham Percival (old account)

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix bookpart identifier crash with page-marker.

Patch Set 1 #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	lily/page-breaking.cc	View		5 chunks	+10 lines, -4 lines	0 comments	Download
	M	lily/page-turn-page-breaking.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Graham Percival (old account)

LGTM; regtest comparison shows nothing unexpected, and the docs build from scratch. Please push.

13 years, 4 months ago (2010-12-12 16:22:24 UTC) #3

Graham Percival (old account)

13 years, 4 months ago (2010-12-14 15:37:01 UTC) #4

On 2010/12/12 16:22:24, Graham Percival wrote:
> LGTM; regtest comparison shows nothing unexpected, and the docs build from
> scratch.  Please push.

I've taken the liberty of pushing this; I want to release .43 soon.

Expand All Messages | Collapse All Messages