Issue 355920043: flower/file-name.cc: Fix canonical file name representation.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 355920043: flower/file-name.cc: Fix canonical file name representation.

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 2 months ago by lemzwerg

Modified:
5 years, 2 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

flower/file-name.cc: Fix canonical file name representation. Before this fix, `/foo' was canonicalized to `foo', incorrectly dropping the leading slash. (However, `/foo/bar' was handled fine – this is perhaps the reason that this quite severe bug wasn't detected earlier.) Also add proper tests. This patch also contains the following commit: yaffut.hh: Fix compilation warning.

Patch Set 1 #

Patch Set 2 : Make lilypond's `make doc' succeed; beautifications. #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -16 lines)			Patch
M	flower/file-name.cc	View	1	5 chunks	+15 lines, -12 lines	0 comments	Download
M	flower/file-path.cc	View	1	1 chunk	+15 lines, -2 lines	0 comments	Download
M	flower/include/file-name.hh	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
M	flower/include/yaffut.hh	View		1 chunk	+1 line, -1 line	0 comments	Download
M	flower/test-file-name.cc	View		1 chunk	+18 lines, -1 line	0 comments	Download
M	lily/lily-parser-scheme.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Make lilypond's `make doc' succeed; beautifications.

Expand All Messages | Collapse All Messages