Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4054)

Issue 3538041: Use wildcard pattern in default.xml to set the default value. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by Daiki Ueno
Modified:
13 years, 4 months ago
Reviewers:
shawn.p.huang, Peng
Base URL:
git@github.com:ibus/ibus-m17n.git@master
Visibility:
Public.

Description

Use wildcard pattern in default.xml to set the default value. Move the default config value (rank = 0, preedit_highlight = FALSE) to default.xml, using wildcard pattern. Also reorder entries in default.xml and add note about the matching order. BUG=none TEST=manual

Patch Set 1 #

Patch Set 2 : fix memleak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -73 lines) Patch
M src/default.xml.in.in View 3 chunks +59 lines, -48 lines 0 comments Download
M src/m17nutil.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/m17nutil.c View 1 9 chunks +26 lines, -23 lines 0 comments Download

Messages

Total messages: 2
Daiki Ueno
13 years, 4 months ago (2010-12-09 06:54:32 UTC) #1
Peng
13 years, 4 months ago (2010-12-09 10:19:58 UTC) #2
LGTM
On 2010/12/09 06:54:32, Daiki Ueno wrote:
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b