Issue 35360044: Fix crash on non-ascii in macro name

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 35360044: Fix crash on non-ascii in macro name (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by xiaq

Modified:
11 years, 2 months ago

Reviewers:
thomas.j.waldmann

Visibility:
Public.

More Reviews

Description

Fix crash on non-ascii in macro name

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	MoinMoin/macro/__init__.py	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Thomas.J.Waldmann

11 years, 2 months ago (2013-11-30 10:50:07 UTC) #1

https://codereview.appspot.com/35360044/diff/1/MoinMoin/macro/__init__.py
File MoinMoin/macro/__init__.py (right):

https://codereview.appspot.com/35360044/diff/1/MoinMoin/macro/__init__.py#new...
MoinMoin/macro/__init__.py:109: })
looks valid :)

as most of the code in execute() uses macro_name (not self.name), you could do
that also.

Expand All Messages | Collapse All Messages