Issue 351880043: Issue 5485: avoid -Wsequence-point warning

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 351880043: Issue 5485: avoid -Wsequence-point warning

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 1 month ago by Malte Meyn

Modified:
5 years, 1 month ago

Reviewers:
Valentin Villenave, dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 5485: avoid -Wsequence-point warning

Patch Set 2 : Ouch. Didn’t test and forgot the ! #

Total comments: 1

Patch Set 3 : Make it (nearly) as efficient as it was before. #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	lily/page-turn-page-breaking.cc	View	1 2	1 chunk	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Valentin Villenave

Greetings Malte, nice catch! I’d been struggling with it for a while. I believe that’s ...

5 years, 1 month ago (2019-02-28 13:08:32 UTC) #2

dak

https://codereview.appspot.com/351880043/diff/20001/lily/page-turn-page-breaking.cc File lily/page-turn-page-breaking.cc (right): https://codereview.appspot.com/351880043/diff/20001/lily/page-turn-page-breaking.cc#newcode37 lily/page-turn-page-breaking.cc:37: bool page_breakable = scm_is_symbol (g->get_property ("page-break-permission")); This always looks ...

5 years, 1 month ago (2019-02-28 13:19:11 UTC) #3

Malte Meyn

5 years, 1 month ago (2019-02-28 14:25:26 UTC) #5

On 2019/02/28 14:22:35, Malte Meyn wrote:
> Make it (nearly) as efficient as it was before.

“nearly” because (!line_breakable || !page_breakable) might need only the
line_breakable lookup. But I thought we have enough “if”s here already …

Expand All Messages | Collapse All Messages