Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10790)

Issue 35080044: Issue 185: Remove Pitch_squash_engraver

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by dak
Modified:
10 years, 5 months ago
Reviewers:
J. Rohrer
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 185: Remove Pitch_squash_engraver Actually, this issue is called "RhythmicStaff squishing chords should produce single notes" and that's one thing that it does. But in the course of it, it completely replaces the Pitch_squash_engraver since the Note_heads_engraver has to look at squashedPosition anyway in order to decide how many note events to handle. Articulations and fingerings on spurious noteheads get lost when squashing. It would be conceivable to transfer them to the remaining note event, but it's not clear that this would not cause problems of its own. Contains convert-ly rules as well. Additional commits: Perfunctorily remove bad links to Pitch_squash_engraver in translations A few documentation fixes after removing Pitch_squash_engraver Run scripts/auxiliar/update-with-convert-ly.sh

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -164 lines) Patch
M Documentation/de/essay/engraving.itely View 3 chunks +1 line, -3 lines 0 comments Download
M Documentation/de/notation/changing-defaults.itely View 4 chunks +1 line, -4 lines 0 comments Download
M Documentation/de/notation/pitches.itely View 3 chunks +2 lines, -3 lines 0 comments Download
M Documentation/de/notation/rhythms.itely View 3 chunks +2 lines, -3 lines 0 comments Download
M Documentation/es/essay/engraving.itely View 3 chunks +1 line, -3 lines 0 comments Download
M Documentation/es/notation/changing-defaults.itely View 5 chunks +2 lines, -5 lines 0 comments Download
M Documentation/es/notation/pitches.itely View 3 chunks +2 lines, -3 lines 0 comments Download
M Documentation/es/notation/rhythms.itely View 3 chunks +2 lines, -3 lines 0 comments Download
M Documentation/essay/engraving.itely View 3 chunks +1 line, -3 lines 0 comments Download
M Documentation/fr/essay/engraving.itely View 3 chunks +1 line, -3 lines 0 comments Download
M Documentation/fr/notation/changing-defaults.itely View 5 chunks +2 lines, -5 lines 0 comments Download
M Documentation/fr/notation/pitches.itely View 3 chunks +2 lines, -3 lines 0 comments Download
M Documentation/fr/notation/rhythms.itely View 3 chunks +2 lines, -3 lines 0 comments Download
M Documentation/it/notation/pitches.itely View 3 chunks +2 lines, -3 lines 0 comments Download
M Documentation/it/notation/rhythms.itely View 3 chunks +2 lines, -3 lines 0 comments Download
M Documentation/ja/notation/changing-defaults.itely View 4 chunks +2 lines, -5 lines 0 comments Download
M Documentation/ja/notation/pitches.itely View 3 chunks +2 lines, -3 lines 0 comments Download
M Documentation/ja/notation/rhythms.itely View 3 chunks +2 lines, -3 lines 0 comments Download
M Documentation/notation/changing-defaults.itely View 5 chunks +3 lines, -8 lines 0 comments Download
M Documentation/notation/pitches.itely View 3 chunks +3 lines, -5 lines 0 comments Download
M Documentation/notation/rhythms.itely View 3 chunks +3 lines, -7 lines 0 comments Download
M Documentation/snippets/engravers-one-by-one.ly View 3 chunks +1 line, -3 lines 0 comments Download
M Documentation/snippets/guitar-strum-rhythms.ly View 2 chunks +1 line, -2 lines 0 comments Download
M input/regression/no-staff.ly View 2 chunks +1 line, -2 lines 0 comments Download
M lily/include/lily-proto.hh View 2 chunks +0 lines, -3 lines 0 comments Download
M lily/note-heads-engraver.cc View 2 chunks +11 lines, -0 lines 0 comments Download
D lily/pitch-squash-engraver.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M ly/engraver-init.ly View 3 chunks +4 lines, -3 lines 0 comments Download
M python/convertrules.py View 1 chunk +7 lines, -0 lines 0 comments Download
M scm/define-context-properties.scm View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2
J. Rohrer
To make sure I understand correctly (unfortunately I cannot test the patch right now, I ...
10 years, 5 months ago (2013-11-29 19:28:44 UTC) #1
dak
10 years, 5 months ago (2013-11-29 23:31:56 UTC) #2
On 2013/11/29 19:28:44, J. Rohrer wrote:
> To make sure I understand correctly (unfortunately I cannot test the patch
right
> now, I only looked over the diffs): After this change,
> 
> - you can still freely mix squashed and unsquashed voices in one staff,

Yes.  The Pitch_squash_engraver actually does exactly that: if squashedPosition
is not set to a numeric value, it does nothing.

> - to squash notes in one voice, you just set Voice.squashedPosition to an
> appropriate numeric value, and
> - to stop squashing again, you set it to #f (anything non-numeric actually).
> 
> Correct?

Not "anything non-numeric": LilyPond will protest against most.  #f and #'() are
always permitted (#f switches off, and #'() defers judgment to the parent
context setting).

And it only affects Note_heads_engraver for now: Pitch_squash_engraver worked on
anything including custom engravers.  I did not see the point for
Drum_notes_engraver but may be convinced otherwise.

> If so, this is a nice simplification IMO.

The most logical simplification would have been
\override NoteHead.staff-position = #0
but that could not easily have been made to encompass the "leave only one
notehead" functionality.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b