Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2649)

Issue 34880043: Implement \beamExceptions function fishing exceptions from beamed music. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by dak
Modified:
10 years, 2 months ago
Reviewers:
Graham Percival, janek
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Implement \beamExceptions function fishing exceptions from beamed music. Also contains commits Change documentation and regtests for \beamExceptions Add unfold-repeats-fully function which will expand repeats in the data

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -62 lines) Patch
M Documentation/notation/rhythms.itely View 2 chunks +11 lines, -28 lines 0 comments Download
M input/regression/auto-beam-exceptions.ly View 2 chunks +9 lines, -29 lines 0 comments Download
M input/regression/les-nereides.ly View 2 chunks +4 lines, -3 lines 0 comments Download
M input/regression/tablature-slurs-with-beams.ly View 2 chunks +3 lines, -2 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +8 lines, -0 lines 0 comments Download
M scm/auto-beam.scm View 1 chunk +49 lines, -0 lines 0 comments Download
M scm/music-functions.scm View 3 chunks +53 lines, -0 lines 0 comments Download

Messages

Total messages: 2
janek
I very much like the simplification in the user interface! If i understand correctly, this ...
10 years, 5 months ago (2013-12-01 12:32:34 UTC) #1
dak
10 years, 5 months ago (2013-12-01 13:01:40 UTC) #2
On 2013/12/01 12:32:34, janek wrote:
> I very much like the simplification in the user interface!
> If i understand correctly, this function will overwrite beamExceptions with
the
> pattern extracted from the music.

No.  It converts the given music into a form that can be placed into the
beamExceptions property.  Examples and documentation are intended to be quite
clear about that.  Please point out where you consider it deficient.

> Would it be possible to instead have a function \addBeamException that would
> take just one pattern and _add it_ to the current beamExceptions?  I think
that
> would make the user interface even better.

There is no "instead".  What you do with the extracted data is your own choice. 
Assigning to beamExceptions via \set is one obvious use case.  Using it as an
argument in \overrideBeamSettings is another.  If you want to write a function
that will use applyContext for getting the existing setting and merging it with
something you may specify in Scheme or by using \beamExceptions, feel free to do
so in a separate issue.

I don't think that there is much of a point to it since beam exceptions act as a
set and having too many closely named functions for fiddling with beam settings
will confuse rather than help.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b