Issue 34840045: issue 3683, fingering collides

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 34840045: issue 3683, fingering collides

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by Keith

Modified:
10 years, 5 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

issue 3683, fingering collides two commits Revert "side-position-interface: do not recursively add support" pointer-group-interface: no need to remove_duplicates on every addition

Patch Set 1 : Revert 3312ca32 #

Patch Set 2 : remove excessive remove_duplicates() calls #

Total comments: 1

Patch Set 3 : simpler #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	lily/script-column.cc	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Keith

10 years, 5 months ago (2013-11-28 21:45:39 UTC) #1

https://codereview.appspot.com/34840045/diff/60001/lily/script-column.cc
File lily/script-column.cc (right):

https://codereview.appspot.com/34840045/diff/60001/lily/script-column.cc#newc...
lily/script-column.cc:159: Side_position_interface::recursive_add_support (g,
last);
It might be better to explicitly add the earlier scripts to the support of this
new script in a a nested loop right here (but that would require writing code
and I can only rearrange code)

Expand All Messages | Collapse All Messages