Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(207)

Issue 347950043: Issue 5409: Fix many type-conversion warnings in simple-spacer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by Dan Eble
Modified:
5 years, 6 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5409/ Most of these changes eliminate a conversion from int to vsize (a.k.a. size_t) by changing the public interface to use vsize. I understand that whether to use signed or unsigned numbers for indexing is a polarizing issue. I prefer using size_t for consistency with the standard library, but if there are strong opinions the other way, I'm willing to rework this patch to restore int to the public interface and cast to size_t in the implementation. These warnings were observed when building with g++ 8.0.1 on x86_64.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M lily/include/simple-spacer.hh View 2 chunks +4 lines, -4 lines 0 comments Download
M lily/simple-spacer.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M lily/simple-spacer-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b