On 2018/08/03 03:24:40, lemzwerg wrote: > LGTM. I suggest that you do such trivial clean-ups ...
5 years, 8 months ago
(2018-08-03 06:52:29 UTC)
#2
On 2018/08/03 03:24:40, lemzwerg wrote:
> LGTM. I suggest that you do such trivial clean-ups directly in the git
> repository, not wasting your time with setting up an issue.
If Han-Wen did not see fit to remove the line but instead went to the trouble of
adding a "WTF?" comment, I think removing without an opportunity for people to
check would be optimistic. Also I leave a record that way.
On 2018/08/03 08:25:32, hanwenn wrote: > LGTM Thanks. For the record, I am currently renaming ...
5 years, 8 months ago
(2018-08-03 08:51:12 UTC)
#4
On 2018/08/03 08:25:32, hanwenn wrote:
> LGTM
Thanks. For the record, I am currently renaming get_property and set_property
for grobs since I want to change their internals in a manner not compatible with
the existing get_property macro (which does not get to know what kind of class
it is being used on). So I did a rename job for all known grob properties
(quite a nuisance because probably 15% of stuff like "direction" or "text" ended
up not being a grob property after all) and cleaned up afterwards. And a few
things just didn't clean up.
This is one.
Issue 347930043: fingering-engraver.cc: don't set Fingering.pitch
Created 5 years, 8 months ago by dak
Modified 5 years, 8 months ago
Reviewers: lemzwerg, hanwenn
Base URL:
Comments: 0