Issue 3475041: Use gnome-autogen.sh to generate configure and Makefiles.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3475041: Use gnome-autogen.sh to generate configure and Makefiles. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Daiki Ueno

Modified:
13 years, 4 months ago

Reviewers:
shawn.p.huang

Base URL:
git@github.com:ibus/ibus-m17n.git@master

Visibility:
Public.

Description

Use gnome-autogen.sh to generate configure and Makefiles. BUG=none TEST=manual

Patch Set 2 : set default CFLAGS and CXXFLAGS #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -10 lines)			Patch
	M	autogen.sh	View	1	1 chunk	+24 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Daiki Ueno

Though I'm not sure if it is agreed to use gnome-autogen.sh in engines, it would ...

13 years, 4 months ago (2010-12-06 01:32:53 UTC) #1

Peng

http://codereview.appspot.com/3475041/diff/1/autogen.sh File autogen.sh (left): http://codereview.appspot.com/3475041/diff/1/autogen.sh#oldcode12 autogen.sh:12: export CXXFLAGS="$CFLAGS" It is better to keep CFLAGS and ...

13 years, 4 months ago (2010-12-06 06:26:16 UTC) #2

Daiki Ueno

Thanks for the review. http://codereview.appspot.com/3475041/diff/1/autogen.sh File autogen.sh (left): http://codereview.appspot.com/3475041/diff/1/autogen.sh#oldcode12 autogen.sh:12: export CXXFLAGS="$CFLAGS" On 2010/12/06 06:26:16, ...

13 years, 4 months ago (2010-12-06 07:08:56 UTC) #3

LGTM. Thanks,

Expand All Messages | Collapse All Messages