Issue 346130043: Issue 5387: align brackets only to visible Stems

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 346130043: Issue 5387: align brackets only to visible Stems

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 9 months ago by Malte Meyn

Modified:
5 years, 9 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 5387: align brackets only to visible Stems TupletBrackets and LigatureBrackets now don’t take into account stems of rests, whole and longer notes and stems that are omitted. Contains regtests.

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -1 line)			Patch
A	input/regression/ligature-bracket-X-positions.ly	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	input/regression/tuplet-bracket-X-positions.ly	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	lily/tuplet-bracket.cc	View	1 chunk	+6 lines, -1 line	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Malte Meyn

5 years, 9 months ago (2018-07-19 14:58:47 UTC) #1

This doesn’t follow Gould (see sf tracker for her suggestion) but modifies
LilyPond’s current behaviour: If there is a stem on the same side/direction,
align to that. Else align to the rest/note head.

https://codereview.appspot.com/346130043/diff/1/lily/tuplet-bracket.cc
File lily/tuplet-bracket.cc (right):

https://codereview.appspot.com/346130043/diff/1/lily/tuplet-bracket.cc#newcode75
lily/tuplet-bracket.cc:75: && unsmob<Stencil> (s->get_property ("stencil")))
I tried to put this check (does the Stem have a stencil?) into
Stem::is_invisible but that seems to be the wrong thing.

Expand All Messages | Collapse All Messages