Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(415)

Issue 344960043: Fix GC issue in skyline rotations

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by dak
Modified:
5 years, 9 months ago
Reviewers:
Be-3
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix GC issue in skyline rotations This was issue 5341 initially and is a fix for a problem introduced during issue 5319. The problem basically is that a rotated Stencil is created and its stencil expression is getting stored on the heap without retaining any pointer to it in areas scanned during garbage collections. This fix is a minimal one that merely avoids creating a stencil and instead simulates the effect on the transform matrix to be expected from using a rotated stencil.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M lily/stencil-integral.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2
Be-3
First of all: thanks for taking care of this issue! But the resulting skylines don't ...
5 years, 9 months ago (2018-06-16 12:33:50 UTC) #1
dak
5 years, 9 months ago (2018-06-16 13:30:38 UTC) #2
On 2018/06/16 12:33:50, Be-3 wrote:
> First of all: thanks for taking care of this issue!
> But the resulting skylines don't quite work as expected yet (see attached
image
> in the issue tracker). Seems to be a problem with the centre of rotation
> co-ordinates.
> 
> Greetings,
> Torsten

I assumed that the center coordinates of Stencil::rotate are, well, the center
coordinates.  They aren't.  They are some sort of relative contraption focused
around the bounding box.  Unlikely I'll get this fixed today but I'll probably
try on the train.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b