Skia: Filling non-clipped skipped lines with SkPath::kInverseWinding_FillType.

A fix for http://code.google.com/p/skia/issues/detail?id=87.

Even when SkPath::kInverseWinding_FillType is given,
Skia leaves some lines not filled(cleared) in a case.
This patch is to handle that path.

[morrita, 2010-12-03 06:06:19]

Hi Adam, Steve, could you take a look?
This skia fix is for http://crbug.com/64445,
is small and has a test for it ;-)

[Steve VanDeBogart, 2010-12-03 18:52:12]

agl: I leave approval to you.

I have mostly been working at the API level so I have no idea if this is the
right way to solve your problem.  A couple nits:

http://codereview.appspot.com/3443041/diff/2001/src/core/SkScan_Path.cpp
File src/core/SkScan_Path.cpp (right):

http://codereview.appspot.com/3443041/diff/2001/src/core/SkScan_Path.cpp#newc...
src/core/SkScan_Path.cpp:513: blitter->blitRect(clipRect.fLeft << shiftEdgesUp,
clipRect.fTop << shiftEdgesUp,
Might be nice to keep this to 80 columns.

http://codereview.appspot.com/3443041/diff/2001/tests/FillPathTest.cpp
File tests/FillPathTest.cpp (right):

http://codereview.appspot.com/3443041/diff/2001/tests/FillPathTest.cpp#newcode1
tests/FillPathTest.cpp:1: #include "Test.h"
Add a copyright?  I know most of the other files don't have one, but new ones
do.

http://codereview.appspot.com/3443041/diff/2001/tests/tests_files.mk
File tests/tests_files.mk (right):

http://codereview.appspot.com/3443041/diff/2001/tests/tests_files.mk#newcode4
tests/tests_files.mk:4: FillPathTest.cpp \
You'll need to refresh your repo and rebase your patch.  I alphabetized this
file yesterday.

[morrita, 2010-12-06 01:23:44]

Hi Steve, thank you for reviewing!
I updated the patch to address your feedback.

agl: Could you take a look?

http://codereview.appspot.com/3443041/diff/2001/src/core/SkScan_Path.cpp
File src/core/SkScan_Path.cpp (right):

http://codereview.appspot.com/3443041/diff/2001/src/core/SkScan_Path.cpp#newc...
src/core/SkScan_Path.cpp:513: blitter->blitRect(clipRect.fLeft << shiftEdgesUp,
clipRect.fTop << shiftEdgesUp,
On 2010/12/03 18:52:12, Steve VanDeBogart wrote:
> Might be nice to keep this to 80 columns.

Done.

http://codereview.appspot.com/3443041/diff/2001/tests/FillPathTest.cpp
File tests/FillPathTest.cpp (right):

http://codereview.appspot.com/3443041/diff/2001/tests/FillPathTest.cpp#newcode1
tests/FillPathTest.cpp:1: #include "Test.h"
On 2010/12/03 18:52:12, Steve VanDeBogart wrote:
> Add a copyright?  I know most of the other files don't have one, but new ones
> do.

Done.

[agl, 2010-12-06 18:32:19]

LGTM, landing.

[agl, 2010-12-06 18:52:49]

r630

[morrita, 2010-12-07 01:10:18]

Thanks for your r+ and landing !

[morrita, 2010-12-07 05:54:39]

Agl, could you take a look at https://bugs.webkit.org/show_bug.cgi?id=41576 ?
It isn't directly relating Skia. But It looks your territory ;-)
Thanks in advance.

[agl, 2010-12-07 14:30:05]

On Tue, Dec 7, 2010 at 12:54 AM,  <morrita@google.com> wrote:
> Agl, could you take a look at
> https://bugs.webkit.org/show_bug.cgi?id=41576 ?
> It isn't directly relating Skia. But It looks your territory ;-)
> Thanks in advance.

I'm afraid that I'm not doing Skia nor font bugs for the foreseeable
future. I'm pretty much booked out for the next six months on
networking stuff.


AGL

[morrita, 2010-12-07 15:01:13]

> I'm afraid that I'm not doing Skia nor font bugs for the foreseeable
> future. I'm pretty much booked out for the next six months on
> networking stuff.
Ah, I didn't notice that. I'm sorry for disturbing.
I submitted a small patch for that (Bug 41576) so
I will be happy if you did a review when you did some WebKit review for
your current working area. Nico Weber recommended you ;-)

Regards
--
morrita

On Tue, Dec 7, 2010 at 11:30 PM, Adam Langley <agl@chromium.org> wrote:
> On Tue, Dec 7, 2010 at 12:54 AM,  <morrita@google.com> wrote:
>> Agl, could you take a look at
>> https://bugs.webkit.org/show_bug.cgi?id=41576 ?
>> It isn't directly relating Skia. But It looks your territory ;-)
>> Thanks in advance.
>
> I'm afraid that I'm not doing Skia nor font bugs for the foreseeable
> future. I'm pretty much booked out for the next six months on
> networking stuff.
>
>
> AGL
>



-- 
morrita