src/cmd/gc/typecheck.c - Issue 3435042: code review 3435042: Fixes issue 1324.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/gc/typecheck.c

Issue 3435042: code review 3435042: Fixes issue 1324. (Closed)

Patch Set: code review 3435042: Fixes issue 1324. Created 1 year, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/gc/typecheck.c

===================================================================

--- a/src/cmd/gc/typecheck.c

+++ b/src/cmd/gc/typecheck.c

@@ -68,7 +68,7 @@

Node *n, *l, *r;

NodeList *args;

int lno, ok, ntop;

- Type *t, *missing, *have;

+ Type *t, *tp, *missing, *have;

Sym *sym;

Val v;

char *why;

@@ -520,6 +520,7 @@

ok = Erv;

goto ret;

}

+ tp = t;

if(isptr[t->etype] && t->type->etype != TINTER) {

t = t->type;

if(t == T)

@@ -531,7 +532,7 @@

if(lookdot(n, t, 1))

yyerror("%#N undefined (cannot refer to unexported field or method %S)", n, n->right->sym);

else

- yyerror("%#N undefined (type %T has no field or method %S)", n, t, n->right->sym);

+ yyerror("%#N undefined (type %T has no field or method %S)", n, tp, n->right->sym);

goto error;

}

switch(n->op) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »