Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11905)

Issue 343270043: Issue 5345: Stop crash while merging ledger lines

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by dak
Modified:
5 years, 10 months ago
Reviewers:
carl.d.sorensen, Carl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5345: Stop crash while merging ledger lines The old code (part of issue 4979) used quite broken code for merging intervals that could crash eating all memory under certain conditions and failed to account for merging certain interval combinations. The incremental broken merge code has been thrown out and replaced by using the non-incremental Interval_set::union which has been designed for that purpose.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -25 lines) Patch
M lily/ledger-line-spanner.cc View 6 chunks +16 lines, -25 lines 0 comments Download

Messages

Total messages: 1
Carl
5 years, 10 months ago (2018-06-18 04:13:08 UTC) #1
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b