Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3980)

Issue 3416045: Fix 1248 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by Carl
Modified:
13 years, 4 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix 1248 Change test from !scm_is_null to scm_is_pair Add regression test

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
A input/regression/bookpart-variable.ly View 1 chunk +19 lines, -0 lines 0 comments Download
M lily/lily-parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Carl
Here's a proposed patch for allowing a \bookpart variable in a \book.
13 years, 4 months ago (2010-12-03 23:33:07 UTC) #1
Neil Puttock
LGTM. BTW, while looking into this, I was a bit puzzled by the behaviour of ...
13 years, 4 months ago (2010-12-04 00:27:01 UTC) #2
Patrick McCarty
Hi Carl, The code looks good. The patch's subject should have "1428" though, not "1248". ...
13 years, 4 months ago (2010-12-04 01:56:52 UTC) #3
c_sorensen
13 years, 4 months ago (2010-12-04 02:36:01 UTC) #4

On Dec 3, 2010, at 6:57 PM, "pnorcks@gmail.com" <pnorcks@gmail.com>  
wrote:

> Hi Carl,
>
> The code looks good.
>
> The patch's subject should have "1428" though, not "1248".
>
>

You know, my kids have dyslexia -- and the older I get the more it  
affects me. Thanks for the catch!

Carl
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b