LGTM. BTW, while looking into this, I was a bit puzzled by the behaviour of ...
13 years, 4 months ago
(2010-12-04 00:27:01 UTC)
#2
LGTM.
BTW, while looking into this, I was a bit puzzled by the behaviour of the
identifier inside the \book block: it isn't a \bookpart unless it's encapsulated
in another \bookpart block since the parser makes no distinction between \book
and \bookpart identifiers: the regtest snippet is functionally equivalent to the
following:
mypart = \book {
\relative c' {
c1
}
}
\book {
\mypart
}
On Dec 3, 2010, at 6:57 PM, "pnorcks@gmail.com" <pnorcks@gmail.com> wrote: > Hi Carl, > > ...
13 years, 4 months ago
(2010-12-04 02:36:01 UTC)
#4
On Dec 3, 2010, at 6:57 PM, "pnorcks@gmail.com" <pnorcks@gmail.com>
wrote:
> Hi Carl,
>
> The code looks good.
>
> The patch's subject should have "1428" though, not "1248".
>
>
You know, my kids have dyslexia -- and the older I get the more it
affects me. Thanks for the catch!
Carl
Issue 3416045: Fix 1248
(Closed)
Created 13 years, 4 months ago by Carl
Modified 13 years, 4 months ago
Reviewers: Neil Puttock, Patrick McCarty, c_sorensen
Base URL:
Comments: 0