Issue 5489: improve prall glyphs

Issue 5489: improve prall glyphs

• rename trilelement → trillelement
• fix erroneous shape of pralldown/prallup
• enlarge arc of downprall/pralldown
• move and shorten line of lineprall

[Malte Meyn, 2019-03-03 08:55:16]

https://codereview.appspot.com/341560043/diff/1/mf/feta-trills.mf
File mf/feta-trills.mf (right):

https://codereview.appspot.com/341560043/diff/1/mf/feta-trills.mf#newcode265
mf/feta-trills.mf:265: .. tension 0.95
I’ll fix this indentation error before pushing, I don’t think this needs another
patchset.

[Malte Meyn, 2019-03-03 08:57:58]

forgot encodingdefs.ps … Maybe I’ll learn that one day …

[thomasmorley651, 2019-03-03 09:37:01]

Thanks for correcting the imho wrong spelling of "trilelement".
Please add a conversion rule for it. Sometimes I used "trilelement" and maybe
I'm not the only one.

[Malte Meyn, 2019-03-03 11:36:37]

On 2019/03/03 09:37:01, thomasmorley651 wrote:
> Thanks for correcting the imho wrong spelling of "trilelement".
> Please add a conversion rule for it. Sometimes I used "trilelement" and maybe
> I'm not the only one.

Is it as easy as adding

    str = re.sub (r'"scripts.trilelement"', r'"scripts.trillelement"', str) 

directly after the powerChords rule (line 3979 of convertrules.py)? Or are there
more places where changes should be made?

I thought about adding \musicglyph to the rule above but then the following
wouldn’t be converted correctly:

$@(map (lambda (x) (markup #:musicglyph x))
   '("scripts.trill"
      "scripts.trillelement"))

[dak, 2019-03-03 12:20:41]

lilypond@maltemeyn.de writes:

> On 2019/03/03 09:37:01, thomasmorley651 wrote:
>> Thanks for correcting the imho wrong spelling of "trilelement".
>> Please add a conversion rule for it. Sometimes I used "trilelement"
> and maybe
>> I'm not the only one.
>
> Is it as easy as adding
>
>     str = re.sub (r'"scripts.trilelement"', r'"scripts.trillelement"',
> str)

More like
  str = re.sub (r'"scripts\.trilelement"', r'"scripts\.trillelement"', str)

Sort of ironic to use raw strings here for the sake of easier
backslash-quoting and then not even backslash-quote the necessary parts.

-- 
David Kastrup

[Malte Meyn, 2019-03-03 12:23:54]

On 2019/03/03 12:20:41, dak wrote:
> More like
>   str = re.sub (r'"scripts\.trilelement"', r'"scripts\.trillelement"', str)
> 
> Sort of ironic to use raw strings here for the sake of easier
> backslash-quoting and then not even backslash-quote the necessary parts.

I don’t know anything about python and what the r before the strings means. I
just copied what I saw, that’s why I asked …

[dak, 2019-03-03 12:45:49]

lilypond@maltemeyn.de writes:

> On 2019/03/03 12:20:41, dak wrote:
>> More like
>>    str = re.sub (r'"scripts\.trilelement"', r'"scripts\.trillelement"',
> str)
>
>> Sort of ironic to use raw strings here for the sake of easier
>> backslash-quoting and then not even backslash-quote the necessary
> parts.
>
> I don’t know anything about python and what the r before the strings
> means. I just copied what I saw, that’s why I asked …

I read "it is as easy" rather than the "is it as easy" you actually
wrote.  Sorry for that.  Of course I also made a mistake since while the
first dot needs quoting, the second doesn't.  So it's more like

    str = re.sub (r'"scripts\.trilelement"', r'"scripts.trillelement"', str)


-- 
David Kastrup

[lemzwerg, 2019-03-04 05:28:32]

The mf code looks fine, thanks!

[Malte Meyn, 2019-03-04 07:54:54]

add convert-ly rule