Add flate compression test and fix bugs.

Add flate compression test and fix bugs.

Committed: http://code.google.com/p/skia/source/detail?r=628

[James Hawkins, 2010-12-02 00:55:59]

http://codereview.appspot.com/3393041/diff/1/src/core/SkFlate.cpp
File src/core/SkFlate.cpp (right):

http://codereview.appspot.com/3393041/diff/1/src/core/SkFlate.cpp#newcode99
src/core/SkFlate.cpp:99: if (flateData.avail_out < kBufferSize) {
Is it possible to write a test for this?

[Steve VanDeBogart, 2010-12-02 21:38:12]

Shame on me.  It wasn't that hard to write a test that caught this - and also
caught two other bugs.

http://codereview.appspot.com/3393041/diff/5001/tests/tests_files.mk
File tests/tests_files.mk (right):

http://codereview.appspot.com/3393041/diff/5001/tests/tests_files.mk#newcode2
tests/tests_files.mk:2: BitmapCopyTest.cpp \
Alphabetized this file as well as adding Flate.cpp

[James Hawkins, 2010-12-02 22:39:54]

LGTM

http://codereview.appspot.com/3393041/diff/5001/tests/FlateTest.cpp
File tests/FlateTest.cpp (right):

http://codereview.appspot.com/3393041/diff/5001/tests/FlateTest.cpp#newcode26
tests/FlateTest.cpp:26: class SkSimulatedFileStream : public SkMemoryStream {
nit: Might be more clear to name this something like SkZeroSizeFileStream, etc.

[Steve VanDeBogart, 2010-12-02 22:54:10]

Thanks

http://codereview.appspot.com/3393041/diff/5001/tests/FlateTest.cpp
File tests/FlateTest.cpp (right):

http://codereview.appspot.com/3393041/diff/5001/tests/FlateTest.cpp#newcode26
tests/FlateTest.cpp:26: class SkSimulatedFileStream : public SkMemoryStream {
On 2010/12/02 22:39:54, James Hawkins wrote:
> nit: Might be more clear to name this something like SkZeroSizeFileStream,
etc.

Done.