Issue 3393041: Add flate compression test and fix bugs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3393041: Add flate compression test and fix bugs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 12 months ago by Steve VanDeBogart

Modified:
13 years, 12 months ago

Reviewers:
James Hawkins

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Add flate compression test and fix bugs. Committed: http://code.google.com/p/skia/source/detail?r=628

Patch Set 2 : Add test and fix other bugs. #

Total comments: 3

Patch Set 3 : Nit #

Created: 13 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -17 lines)			Patch
M	src/core/SkFlate.cpp	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
A	tests/FlateTest.cpp	View		1 chunk	+107 lines, -0 lines	0 comments	Download
M	tests/tests_files.mk	View		1 chunk	+14 lines, -13 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

James Hawkins

http://codereview.appspot.com/3393041/diff/1/src/core/SkFlate.cpp File src/core/SkFlate.cpp (right): http://codereview.appspot.com/3393041/diff/1/src/core/SkFlate.cpp#newcode99 src/core/SkFlate.cpp:99: if (flateData.avail_out < kBufferSize) { Is it possible to ...

13 years, 12 months ago (2010-12-02 00:55:59 UTC) #2

Steve VanDeBogart

Shame on me. It wasn't that hard to write a test that caught this - ...

13 years, 12 months ago (2010-12-02 21:38:12 UTC) #3

James Hawkins

LGTM http://codereview.appspot.com/3393041/diff/5001/tests/FlateTest.cpp File tests/FlateTest.cpp (right): http://codereview.appspot.com/3393041/diff/5001/tests/FlateTest.cpp#newcode26 tests/FlateTest.cpp:26: class SkSimulatedFileStream : public SkMemoryStream { nit: Might ...

13 years, 12 months ago (2010-12-02 22:39:54 UTC) #4

Steve VanDeBogart

13 years, 12 months ago (2010-12-02 22:54:10 UTC) #5

Thanks

http://codereview.appspot.com/3393041/diff/5001/tests/FlateTest.cpp
File tests/FlateTest.cpp (right):

http://codereview.appspot.com/3393041/diff/5001/tests/FlateTest.cpp#newcode26
tests/FlateTest.cpp:26: class SkSimulatedFileStream : public SkMemoryStream {
On 2010/12/02 22:39:54, James Hawkins wrote:
> nit: Might be more clear to name this something like SkZeroSizeFileStream,
etc.

Done.

Expand All Messages | Collapse All Messages