Issue 33930043: Rewrite the autobeam logic to use GUILE fractions rather than moments

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 33930043: Rewrite the autobeam logic to use GUILE fractions rather than moments (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by dak

Modified:
10 years, 2 months ago

Reviewers:
Keith, janek

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Rewrite the autobeam logic to use GUILE fractions rather than moments This makes the arithmetic considerably clearer.

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -116 lines)			Patch
	M	scm/auto-beam.scm	View	1 2 3	1 chunk	+89 lines, -95 lines	0 comments	Download
	M	scm/time-signature-settings.scm	View	1 2	10 chunks	+20 lines, -21 lines	0 comments	Download

Total messages: 5

Keith

Looks good if you remove the dueling comments in time-signature-settings, which is a source file ...

10 years, 5 months ago (2013-12-03 07:13:46 UTC) #3

Rebase.  Also rewrite and simplify extract-beam-exceptions