Issue 339220043: Let Key_performer heed instrumentTransposition

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 339220043: Let Key_performer heed instrumentTransposition

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 3 months ago by dak

Modified:
6 years, 3 months ago

Reviewers:
Dan Eble

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Let Key_performer heed instrumentTransposition I actually have no good idea how to regtest this one.

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	lily/key-performer.cc	View		2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Dan Eble

6 years, 3 months ago (2018-01-17 00:07:30 UTC) #1

LGTM.  Thanks.

For regression testing, I recall that when I changed the dynamic performer,
there were many MIDI tests in a subdirectory that showed differences in the form
of hex dumps.  They're definitely underwhelming compared to the visual
regression tests, but still better than nothing.

I have no idea whether the MIDI test harness will produce testable output for a
\key command, but if you have time, it might be worth a try.

Expand All Messages | Collapse All Messages