Issue 3392041: Use ibus_m17n_scan_engine_name() to simplify the code.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3392041: Use ibus_m17n_scan_engine_name() to simplify the code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Daiki Ueno

Modified:
13 years, 4 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus-m17n.git@master

Visibility:
Public.

Description

Use ibus_m17n_scan_engine_name() to simplify the code. BUG=none TEST=manual

Patch Set 1 #

Patch Set 2 : Handle errors from ibus_m17n_scan_{engine,class}_name(). #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -17 lines)			Patch
	M	src/engine.c	View	1	7 chunks	+26 lines, -17 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

On 2010/12/02 05:25:00, Daiki Ueno wrote: LGTM. BTW, Do you think should check the return ...

13 years, 4 months ago (2010-12-02 06:08:12 UTC) #2

Daiki Ueno

13 years, 4 months ago (2010-12-02 07:36:34 UTC) #3

On 2010/12/02 06:08:12, Shawn.P.Huang wrote:
> On 2010/12/02 05:25:00, Daiki Ueno wrote:
> 
> LGTM. BTW, Do you think should check the return value of the scan function?

Yeah uploaded a new patch to check the errors.  Thanks for the review.

Expand All Messages | Collapse All Messages