Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(649)

Issue 3381041: hgnested patch to work with mercurial 1.7 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by ced
Modified:
13 years, 3 months ago
Reviewers:
Ian Wilson, yangoon1
Visibility:
Public.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -13 lines) Patch
M hgnested/__init__.py View 3 chunks +39 lines, -13 lines 3 comments Download

Messages

Total messages: 4
yangoon1
13 years, 4 months ago (2010-12-02 18:15:24 UTC) #1
Ian Wilson
Nitpic about version detection. http://codereview.appspot.com/3381041/diff/1/hgnested/__init__.py File hgnested/__init__.py (right): http://codereview.appspot.com/3381041/diff/1/hgnested/__init__.py#newcode24 hgnested/__init__.py:24: if mercurial_version >= '1.7': Comparing ...
13 years, 4 months ago (2010-12-02 20:18:02 UTC) #2
ced
http://codereview.appspot.com/3381041/diff/1/hgnested/__init__.py File hgnested/__init__.py (right): http://codereview.appspot.com/3381041/diff/1/hgnested/__init__.py#newcode24 hgnested/__init__.py:24: if mercurial_version >= '1.7': On 2010/12/02 20:18:02, Ian Wilson ...
13 years, 4 months ago (2010-12-02 20:49:15 UTC) #3
ced
13 years, 4 months ago (2010-12-02 21:27:38 UTC) #4
http://codereview.appspot.com/3381041/diff/1/hgnested/__init__.py
File hgnested/__init__.py (right):

http://codereview.appspot.com/3381041/diff/1/hgnested/__init__.py#newcode24
hgnested/__init__.py:24: if mercurial_version >= '1.7':
On 2010/12/02 20:49:15, ced wrote:
> On 2010/12/02 20:18:02, Ian Wilson wrote:
> > Comparing strings seems like it could be problematic eventually.  Ie.
('1.10'
> <
> > '1.7') == True. Doesn't setuptools or distutils provide a proper version
> wrapper
> > for comparison?
> 
> I did not find better solution.

Perhaps I could use something like:

map(int, mercurial_version.split('.')) >= [1, 7]

But it will be for an other patch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b