Issue 3381041: hgnested patch to work with mercurial 1.7

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3381041: hgnested patch to work with mercurial 1.7 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by ced

Modified:
14 years, 4 months ago

Reviewers:
Ian Wilson, yangoon1

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -13 lines)			Patch
	M	hgnested/__init__.py	View		3 chunks	+39 lines, -13 lines	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Ian Wilson

Nitpic about version detection. http://codereview.appspot.com/3381041/diff/1/hgnested/__init__.py File hgnested/__init__.py (right): http://codereview.appspot.com/3381041/diff/1/hgnested/__init__.py#newcode24 hgnested/__init__.py:24: if mercurial_version >= '1.7': Comparing ...

14 years, 4 months ago (2010-12-02 20:18:02 UTC) #2

ced

http://codereview.appspot.com/3381041/diff/1/hgnested/__init__.py File hgnested/__init__.py (right): http://codereview.appspot.com/3381041/diff/1/hgnested/__init__.py#newcode24 hgnested/__init__.py:24: if mercurial_version >= '1.7': On 2010/12/02 20:18:02, Ian Wilson ...

14 years, 4 months ago (2010-12-02 20:49:15 UTC) #3

ced

14 years, 4 months ago (2010-12-02 21:27:38 UTC) #4

http://codereview.appspot.com/3381041/diff/1/hgnested/__init__.py
File hgnested/__init__.py (right):

http://codereview.appspot.com/3381041/diff/1/hgnested/__init__.py#newcode24
hgnested/__init__.py:24: if mercurial_version >= '1.7':
On 2010/12/02 20:49:15, ced wrote:
> On 2010/12/02 20:18:02, Ian Wilson wrote:
> > Comparing strings seems like it could be problematic eventually.  Ie.
('1.10'
> <
> > '1.7') == True. Doesn't setuptools or distutils provide a proper version
> wrapper
> > for comparison?
> 
> I did not find better solution.

Perhaps I could use something like:

map(int, mercurial_version.split('.')) >= [1, 7]

But it will be for an other patch.

Expand All Messages | Collapse All Messages